Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 2674533007: [TTS][Overlay] Remove onContentLoadFinished. (Closed)

Created:
3 years, 10 months ago by Donn Denman
Modified:
3 years, 10 months ago
Reviewers:
mdjones
CC:
chromium-reviews, twellington+watch_chromium.org, mdjones+watch_chromium.org, donnd+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS][Overlay] Remove onContentLoadFinished. OverlayPanelContent#onContentLoadFinished is being called even when the content was not on the main frame, which is not correct. Looks like we don't really need this notification anyway. It was being called for metrics and to clear out history of error pages in the unlikely case that GWS returns errors for our searches when being preloaded. This CL removes OverlayPanelContent#onContentLoadFinished. BUG=685740 Review-Url: https://codereview.chromium.org/2674533007 Cr-Commit-Position: refs/heads/master@{#448083} Committed: https://chromium.googlesource.com/chromium/src/+/d5d5d71b0f13530359ed35b2cd492609ad2f637d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayContentDelegate.java View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Donn Denman
Matt, PTAL.
3 years, 10 months ago (2017-02-03 17:13:23 UTC) #6
mdjones
lgtm
3 years, 10 months ago (2017-02-03 18:07:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674533007/1
3 years, 10 months ago (2017-02-03 21:12:17 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 22:07:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d5d5d71b0f13530359ed35b2cd49...

Powered by Google App Engine
This is Rietveld 408576698