Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3457)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Issue 2674533007: [TTS][Overlay] Remove onContentLoadFinished. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
index 86e57e69c8f8ecc93e038a816d1bcf1ae2538856..40f74dc894153013ed52656eb40e9c957f0abded 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
@@ -961,26 +961,6 @@ public class ContextualSearchManager implements ContextualSearchManagementDelega
}
@Override
- public void onContentLoadFinished() {
- if (mSearchRequest == null) return;
-
- mSearchPanel.onSearchResultsLoaded(mSearchRequest.wasPrefetch());
-
- // Any time we place a page in a ContentViewCore, clear history if needed.
- // This prevents error URLs from appearing in the Tab's history stack.
- // Also please note that clearHistory() will not
- // clear the current entry (search results page in this case),
- // and it will not work properly if there are pending navigations.
- // That's why we need to clear the history here, after the navigation
- // is completed.
- boolean shouldClearHistory = mSearchRequest.getHasFailed();
- if (shouldClearHistory && mSearchPanel.getContentViewCore() != null) {
- mSearchPanel.getContentViewCore().getWebContents().getNavigationController()
- .clearHistory();
- }
- }
-
- @Override
public void onVisibilityChanged(boolean isVisible) {
if (isVisible) {
mWereSearchResultsSeen = true;
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698