Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2674293003: [ObjC ARC] Converts ios/chrome/browser/metrics:eg_tests to ARC. (Closed)

Created:
3 years, 10 months ago by stkhapugin
Modified:
3 years, 10 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, asvitkine+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/metrics:eg_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2674293003 Cr-Commit-Position: refs/heads/master@{#448338} Committed: https://chromium.googlesource.com/chromium/src/+/1b8ec1250bd59a373acfeb6040ded92310ad315a

Patch Set 1 #

Total comments: 2

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M ios/chrome/browser/metrics/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
stkhapugin
ptal 🐅
3 years, 10 months ago (2017-02-06 17:33:48 UTC) #6
sdefresne
lgtm https://codereview.chromium.org/2674293003/diff/1/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm File ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm (right): https://codereview.chromium.org/2674293003/diff/1/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm#newcode339 ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm:339: // Clear the page so that we can ...
3 years, 10 months ago (2017-02-06 17:47:55 UTC) #7
stkhapugin
Thanks! https://codereview.chromium.org/2674293003/diff/1/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm File ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm (right): https://codereview.chromium.org/2674293003/diff/1/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm#newcode339 ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm:339: // Clear the page so that we can ...
3 years, 10 months ago (2017-02-06 17:58:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674293003/20001
3 years, 10 months ago (2017-02-06 17:59:26 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 19:13:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1b8ec1250bd59a373acfeb6040de...

Powered by Google App Engine
This is Rietveld 408576698