Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm

Issue 2674293003: [ObjC ARC] Converts ios/chrome/browser/metrics:eg_tests to ARC. (Closed)
Patch Set: typo Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/metrics/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
diff --git a/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm b/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
index 4412291e4cb52447680e2025ecc46ac2c7a7c88e..d6d01e0b81420951da64e314f9ba6f99adf4dfd6 100644
--- a/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
+++ b/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
@@ -40,6 +40,10 @@
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/l10n/l10n_util_mac.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
namespace {
const char kTestUrl1[] =
@@ -332,11 +336,11 @@ void SelectTabUsingUI(NSString* title) {
// Reload each tab.
for (NSUInteger i = 0; i < numberOfTabs; i++) {
chrome_test_util::SelectTabAtIndexInCurrentMode(i);
- // Clear the page so that we can check when pade reload is complete.
+ // Clear the page so that we can check when page reload is complete.
__block bool finished = false;
chrome_test_util::GetCurrentWebState()->ExecuteJavaScript(
base::UTF8ToUTF16(kClearPageScript),
- base::BindBlock(^(const base::Value*) {
+ base::BindBlockArc(^(const base::Value*) {
finished = true;
}));
« no previous file with comments | « ios/chrome/browser/metrics/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698