Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 2674253004: [refactor] Remove WebWidget::applyReplacementRange (Closed)
Patch Set: more refactoring Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
index b015b9b24c3c74bcf88b809e27ac3f92d7c83155..e76461f35025a7a6b7260a18bc2abcb945fb213c 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
@@ -705,16 +705,6 @@ bool WebFrameWidgetImpl::getCompositionCharacterBounds(
return true;
}
-// TODO(ekaramad):This method is almost duplicated in WebViewImpl as well. This
-// code needs to be refactored (http://crbug.com/629721).
-void WebFrameWidgetImpl::applyReplacementRange(const WebRange& range) {
- if (LocalFrame* frame = focusedLocalFrameInWidget()) {
dcheng 2017/02/07 07:58:42 Is the reason it's OK to lose this call is because
EhsanK 2017/02/07 17:14:47 Yes. The IME IPC from RenderWidget of local root e
- // TODO(dglazkov): Going from LocalFrame to WebLocalFrameImpl seems
- // silly. What is going on here?
- WebLocalFrameImpl::fromFrame(frame)->selectRange(range);
- }
-}
-
void WebFrameWidgetImpl::setRemoteViewportIntersection(
const WebRect& viewportIntersection) {
// Remote viewports are only applicable to local frames with remote ancestors.

Powered by Google App Engine
This is Rietveld 408576698