Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: third_party/WebKit/Source/web/WebInputMethodControllerImpl.h

Issue 2674253004: [refactor] Remove WebWidget::applyReplacementRange (Closed)
Patch Set: more refactoring Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebInputMethodControllerImpl.h
diff --git a/third_party/WebKit/Source/web/WebInputMethodControllerImpl.h b/third_party/WebKit/Source/web/WebInputMethodControllerImpl.h
index 076933575cab1f0a234a654b645ede49cbb36acb..17ec1e83ffed9a9b8d91d85b7187a125df70c87a 100644
--- a/third_party/WebKit/Source/web/WebInputMethodControllerImpl.h
+++ b/third_party/WebKit/Source/web/WebInputMethodControllerImpl.h
@@ -15,6 +15,7 @@ class InputMethodController;
class LocalFrame;
class WebLocalFrameImpl;
class WebPlugin;
+class WebRange;
class WebString;
class WebInputMethodControllerImpl : public WebInputMethodController {
@@ -29,10 +30,12 @@ class WebInputMethodControllerImpl : public WebInputMethodController {
// WebInputMethodController overrides.
bool setComposition(const WebString& text,
const WebVector<WebCompositionUnderline>& underlines,
+ const WebRange& replacementRange,
int selectionStart,
dglazkov 2017/02/07 16:47:45 Would you consider switching selectionStart/select
EhsanK 2017/02/07 17:14:47 Yes definitely. I filed a bug and assigned it to m
int selectionEnd) override;
bool commitText(const WebString& text,
const WebVector<WebCompositionUnderline>& underlines,
+ const WebRange& replacementRange,
int relativeCaretPosition) override;
bool finishComposingText(
ConfirmCompositionBehavior selectionBehavior) override;

Powered by Google App Engine
This is Rietveld 408576698