[refactor] Remove WebWidget::applyReplacementRange

third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 687 matching lines @@
       DLOG(ERROR) << "Could not retrieve character rectangle at " << i;
       return false;
     }
     result[i] = webrect;
   }
 
   bounds.swap(result);
   return true;
 }
 
-// TODO(ekaramad):This method is almost duplicated in WebViewImpl as well. This
-// code needs to be refactored  (http://crbug.com/629721).
-void WebFrameWidgetImpl::applyReplacementRange(const WebRange& range) {
-  if (LocalFrame* frame = focusedLocalFrameInWidget()) {

[dcheng, 2017/02/07 07:58:42]

Is the reason it's OK to lose this call is because we're relying on the messages
being correctly routed by IPC now?

[EhsanK, 2017/02/07 17:14:47]

Yes. The IME IPC from RenderWidget of local root ends up at the focused frame's
WebInputMethodController. So we should be fine.
Please see this:
https://cs.chromium.org/chromium/src/content/renderer/render_widget.cc?rcl=41...

And this:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/web/WebFrameWi...

-    // TODO(dglazkov): Going from LocalFrame to WebLocalFrameImpl seems
-    // silly. What is going on here?
-    WebLocalFrameImpl::fromFrame(frame)->selectRange(range);
-  }
-}
-
 void WebFrameWidgetImpl::setRemoteViewportIntersection(
     const WebRect& viewportIntersection) {
   // Remote viewports are only applicable to local frames with remote ancestors.
   DCHECK(m_localRoot->parent() && m_localRoot->parent()->isWebRemoteFrame());
 
   if (m_localRoot->frameView()) {
     m_localRoot->frameView()->setViewportIntersectionFromParent(
         viewportIntersection);
   }
 }
@@ skipping 413 matching lines @@
   return nullptr;
 }
 
 LocalFrame* WebFrameWidgetImpl::focusedLocalFrameAvailableForIme() const {
   if (!m_imeAcceptEvents)
     return nullptr;
   return focusedLocalFrameInWidget();
 }
 
 }  // namespace blink