Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2673833004: Revert of binding: Makes xss-DENIED-window-name-navigator deterministic. (Closed)

Created:
3 years, 10 months ago by joedow
Modified:
3 years, 10 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of binding: Makes xss-DENIED-window-name-navigator deterministic. (patchset #2 id:20001 of https://codereview.chromium.org/2673583003/ ) Reason for revert: Builds on https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29 have been consistently failing since this CL was landed. Reverting for that reason. Original issue's description: > binding: Makes xss-DENIED-window-name-navigator deterministic. > > Makes the test result of xss-DENIED-window-name-navigator.html > deterministic and fixes the flakiness. > > BUG=686470 > > Review-Url: https://codereview.chromium.org/2673583003 > Cr-Commit-Position: refs/heads/master@{#447958} > Committed: https://chromium.googlesource.com/chromium/src/+/114e65b6ddfd281fadd15c8ee43894b40b984b91 TBR=haraken@chromium.org,yukishiino@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=686470 Review-Url: https://codereview.chromium.org/2673833004 Cr-Commit-Position: refs/heads/master@{#448021} Committed: https://chromium.googlesource.com/chromium/src/+/dde6e8dff66e9a76131efe6e1f27779ca8abc867

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
joedow
Created Revert of binding: Makes xss-DENIED-window-name-navigator deterministic.
3 years, 10 months ago (2017-02-03 17:43:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673833004/1
3 years, 10 months ago (2017-02-03 17:44:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/dde6e8dff66e9a76131efe6e1f27779ca8abc867
3 years, 10 months ago (2017-02-03 18:04:57 UTC) #6
haraken
LGTM
3 years, 10 months ago (2017-02-03 18:11:47 UTC) #7
Yuki
3 years, 10 months ago (2017-02-06 08:28:09 UTC) #8
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698