Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 2673583003: binding: Makes xss-DENIED-window-name-navigator deterministic. (Closed)

Created:
3 years, 10 months ago by Yuki
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Makes xss-DENIED-window-name-navigator deterministic. Makes the test result of xss-DENIED-window-name-navigator.html deterministic and fixes the flakiness. BUG=686470 Review-Url: https://codereview.chromium.org/2673583003 Cr-Commit-Position: refs/heads/master@{#447958} Committed: https://chromium.googlesource.com/chromium/src/+/114e65b6ddfd281fadd15c8ee43894b40b984b91

Patch Set 1 #

Patch Set 2 : Removed the test expectation for mac. #

Messages

Total messages: 16 (11 generated)
Yuki
Could you review this CL?
3 years, 10 months ago (2017-02-02 14:06:28 UTC) #4
haraken
LGTM
3 years, 10 months ago (2017-02-02 15:18:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673583003/20001
3 years, 10 months ago (2017-02-03 06:30:07 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/114e65b6ddfd281fadd15c8ee43894b40b984b91
3 years, 10 months ago (2017-02-03 07:36:57 UTC) #15
joedow
3 years, 10 months ago (2017-02-03 17:43:42 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2673833004/ by joedow@chromium.org.

The reason for reverting is: Builds on
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1...
have been consistently failing since this CL was landed.  Reverting for that
reason..

Powered by Google App Engine
This is Rietveld 408576698