Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 267383002: Reland "Removed default Isolate." (Closed)

Created:
5 years ago by Sven Panne
Modified:
5 years ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Reland "Removed default Isolate." Changes compared to original CL: Until the Serializer/Isolate chaos is cleaned up, we can't initalize/dispose cctests in a tidy way, see cctest.cc. BUG=359977 LOG=y R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21205

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -79 lines) Patch
M src/api.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M src/d8.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/isolate.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/isolate.cc View 4 chunks +2 lines, -11 lines 0 comments Download
M src/log.cc View 1 chunk +33 lines, -43 lines 0 comments Download
M src/mksnapshot.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/v8.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M test/cctest/cctest.cc View 2 chunks +6 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
5 years ago (2014-05-07 07:44:10 UTC) #1
dcarney
lgtm
5 years ago (2014-05-07 08:20:23 UTC) #2
Sven Panne
5 years ago (2014-05-09 08:40:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r21205 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698