Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: test/cctest/cctest.cc

Issue 267383002: Reland "Removed default Isolate." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/v8.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/cctest.cc
diff --git a/test/cctest/cctest.cc b/test/cctest/cctest.cc
index b1cf5abb4e62284c2d9ea75942b2f2d0e6f253ef..bd9f7e4b231b32cc804b97f336d4d06fed7abae3 100644
--- a/test/cctest/cctest.cc
+++ b/test/cctest/cctest.cc
@@ -157,6 +157,10 @@ int main(int argc, char* argv[]) {
for (int i = 1; i < argc; i++) {
char* arg = argv[i];
if (strcmp(arg, "--list") == 0) {
+ // TODO(svenpanne) Serializer::enabled() and Serializer::code_address_map_
+ // are fundamentally broken, so we can't unconditionally initialize and
+ // dispose V8.
+ v8::V8::Initialize();
PrintTestList(CcTest::last());
print_run_count = false;
@@ -200,7 +204,8 @@ int main(int argc, char* argv[]) {
if (print_run_count && tests_run != 1)
printf("Ran %i tests.\n", tests_run);
CcTest::TearDown();
- if (!disable_automatic_dispose_) v8::V8::Dispose();
+ // TODO(svenpanne) See comment above.
+ // if (!disable_automatic_dispose_) v8::V8::Dispose();
return 0;
}
« no previous file with comments | « src/v8.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698