Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: src/mksnapshot.cc

Issue 267383002: Reland "Removed default Isolate." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/log.cc ('k') | src/v8.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/mksnapshot.cc
diff --git a/src/mksnapshot.cc b/src/mksnapshot.cc
index a8bf871f1313398be856be2be9600792d7f0bf60..ef0a282a832fa5061af38a5fe991d109045c044e 100644
--- a/src/mksnapshot.cc
+++ b/src/mksnapshot.cc
@@ -393,6 +393,10 @@ int main(int argc, char** argv) {
isolate->Exit();
isolate->Dispose();
- V8::Dispose();
+ // TODO(svenpanne) Alas, we can't cleanly dispose V8 here, because
+ // Serializer::code_address_map_ is static (a.k.a. a global variable), and
+ // disposing that would involve accessing the Isolate just disposed.
+ // code_address_map_ really has to be an instance variable...
+ // V8::Dispose();
return 0;
}
« no previous file with comments | « src/log.cc ('k') | src/v8.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698