Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2673683006: Stop special handling of backslashes in compilation command lines. (Closed)

Created:
3 years, 10 months ago by Łukasz Anforowicz
Modified:
3 years, 10 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop special handling of backslashes in compilation command lines. 1. The special handling was incorrectly mangling URIs (https://crbug.com/688199#c1) 2. The special handling apparently is not needed anymore - clang tool runs fine without it (https://crbug.com/688199#c10) BUG=688199 Review-Url: https://codereview.chromium.org/2673683006 Cr-Commit-Position: refs/heads/master@{#448097} Committed: https://chromium.googlesource.com/chromium/src/+/81048ff960a98b09ce0d37a735c7fe7d4224aceb

Patch Set 1 #

Patch Set 2 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M tools/clang/scripts/generate_win_compdb.py View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Łukasz Anforowicz
dcheng@, can you PTAL?
3 years, 10 months ago (2017-02-03 20:19:49 UTC) #3
dcheng
lgtm
3 years, 10 months ago (2017-02-03 22:30:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673683006/20001
3 years, 10 months ago (2017-02-03 22:36:05 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 22:46:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/81048ff960a98b09ce0d37a735c7...

Powered by Google App Engine
This is Rietveld 408576698