Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/clang/scripts/generate_win_compdb.py

Issue 2673683006: Stop special handling of backslashes in compilation command lines. (Closed)
Patch Set: Rebasing... Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/scripts/generate_win_compdb.py
diff --git a/tools/clang/scripts/generate_win_compdb.py b/tools/clang/scripts/generate_win_compdb.py
index a7a7ba647d83a926c55c7bf195fcd88022bc6a50..6edd5938cb3abb9a74bd15d861d8ed1ef1de8e3d 100755
--- a/tools/clang/scripts/generate_win_compdb.py
+++ b/tools/clang/scripts/generate_win_compdb.py
@@ -48,15 +48,6 @@ def _ProcessEntry(e):
except IOError:
pass
- # TODO(dcheng): This should be implemented in Clang tooling.
- # http://llvm.org/bugs/show_bug.cgi?id=19687
- # Finally, use slashes instead of backslashes to avoid bad escaping by the
- # tooling. This should really only matter for command, but we do it for all
- # keys for consistency.
- e['directory'] = e['directory'].replace('\\', '/')
- e['command'] = e['command'].replace('\\', '/')
- e['file'] = e['file'].replace('\\', '/')
-
return e
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698