Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 267363008: Drop non-standard user gesture requirement from notification.requestPermission (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Drop non-standard user gesture requirement from notification.requestPermission BUG=274284 R=jww@chromium.org,felt@chromium.org,atwilson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270601

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M chrome/browser/notifications/notification_browsertest.cc View 1 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/test/data/notifications/notifications_request_inline.html View 1 1 chunk +0 lines, -10 lines 0 comments Download
M content/renderer/notification_provider.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-08 06:40:54 UTC) #1
jww
On 2014/05/08 06:40:54, jochen wrote: lgtm
6 years, 7 months ago (2014-05-08 07:40:42 UTC) #2
Andrew T Wilson (Slow)
LGTM from a browser compatibility point of view. I'll follow up with chromium-dev around adding ...
6 years, 7 months ago (2014-05-08 08:06:12 UTC) #3
felt
On 2014/05/08 08:06:12, Andrew T Wilson wrote: > LGTM from a browser compatibility point of ...
6 years, 7 months ago (2014-05-08 13:52:18 UTC) #4
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 7 months ago (2014-05-09 06:06:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/267363008/20001
6 years, 7 months ago (2014-05-09 06:09:58 UTC) #6
jochen (gone - plz use gerrit)
The CQ bit was unchecked by jochen@chromium.org
6 years, 7 months ago (2014-05-09 12:53:51 UTC) #7
jochen (gone - plz use gerrit)
On 2014/05/09 12:53:51, jochen wrote: > The CQ bit was unchecked by mailto:jochen@chromium.org let's wait ...
6 years, 7 months ago (2014-05-09 12:54:13 UTC) #8
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 7 months ago (2014-05-15 06:35:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/267363008/20001
6 years, 7 months ago (2014-05-15 06:39:25 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 06:47:43 UTC) #11
Message was sent while issue was closed.
Change committed as 270601

Powered by Google App Engine
This is Rietveld 408576698