Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/renderer/notification_provider.cc

Issue 267363008: Drop non-standard user gesture requirement from notification.requestPermission (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/notifications/notifications_request_inline.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/notification_provider.cc
diff --git a/content/renderer/notification_provider.cc b/content/renderer/notification_provider.cc
index 04f0a4aac265069afa6091634b81fa07674b44e2..79325dcb7ad506f48a6dd06285e27af504861a45 100644
--- a/content/renderer/notification_provider.cc
+++ b/content/renderer/notification_provider.cc
@@ -78,10 +78,6 @@ WebNotificationPresenter::Permission NotificationProvider::checkPermission(
void NotificationProvider::requestPermission(
const WebSecurityOrigin& origin,
WebNotificationPermissionCallback* callback) {
- // We only request permission in response to a user gesture.
- if (!WebUserGestureIndicator::isProcessingUserGesture())
- return;
-
int id = manager_.RegisterPermissionRequest(callback);
Send(new DesktopNotificationHostMsg_RequestPermission(
« no previous file with comments | « chrome/test/data/notifications/notifications_request_inline.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698