Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6129)

Unified Diff: chrome/browser/notifications/notification_browsertest.cc

Issue 267363008: Drop non-standard user gesture requirement from notification.requestPermission (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/notifications/notifications_request_inline.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/notification_browsertest.cc
diff --git a/chrome/browser/notifications/notification_browsertest.cc b/chrome/browser/notifications/notification_browsertest.cc
index 6ec36659e33ec67c2e979dcf5dc91ee0151da9d7..7b942c433c409ec8af3c232c2101f9b931a0eb61 100644
--- a/chrome/browser/notifications/notification_browsertest.cc
+++ b/chrome/browser/notifications/notification_browsertest.cc
@@ -382,22 +382,6 @@ IN_PROC_BROWSER_TEST_F(NotificationsTest, TestUserGestureInfobar) {
EXPECT_EQ(1U, infobar_service->infobar_count());
}
-// If this flakes, use http://crbug.com/62311.
-IN_PROC_BROWSER_TEST_F(NotificationsTest, TestNoUserGestureInfobar) {
- ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
-
- // Load a page which just does a request; no user gesture should result
- // in no infobar.
- ui_test_utils::NavigateToURL(
- browser(),
- embedded_test_server()->GetURL(
- "/notifications/notifications_request_inline.html"));
-
- InfoBarService* infobar_service = InfoBarService::FromWebContents(
- browser()->tab_strip_model()->GetWebContentsAt(0));
- EXPECT_EQ(0U, infobar_service->infobar_count());
-}
-
IN_PROC_BROWSER_TEST_F(NotificationsTest, TestCreateSimpleNotification) {
ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
« no previous file with comments | « no previous file | chrome/test/data/notifications/notifications_request_inline.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698