Issue 2673603002: Allow DomDistillerService to have no store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2673603002: Allow DomDistillerService to have no store. (Closed)

Created:
3 years, 10 months ago by Olivier

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

Allow DomDistillerService to have no store. We do not want storage or sync of distilled versions of page as we store them in files with ReadingListItems. Do not instantiate the store in ReadingList for iOS. BUG=686402 Review-Url: https://codereview.chromium.org/2667533003 Cr-Commit-Position: refs/heads/master@{#447551} (cherry picked from commit b227a4e9a84a3faae02a125085a49906e1b4c54a) Review-Url: https://codereview.chromium.org/2673603002 . Cr-Commit-Position: refs/branch-heads/2987@{#268} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/b39f83e80dfceebfedc15294355e931bc564736e

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -24 lines)			Patch
	M	components/dom_distiller/core/dom_distiller_service.cc	View		8 chunks	+19 lines, -9 lines	0 comments	Download
	M	ios/chrome/browser/dom_distiller/dom_distiller_service_factory.cc	View		2 chunks	+2 lines, -15 lines	0 comments	Download

Total messages: 2 (1 generated)

Olivier

3 years, 10 months ago (2017-02-02 09:10:04 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b39f83e80dfceebfedc15294355e931bc564736e.