Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1671)

Issue 2667533003: Allow DomDistillerService to have no store. (Closed)

Created:
3 years, 10 months ago by Olivier
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow DomDistillerService to have no store. We do not want storage or sync of distilled versions of page as we store them in files with ReadingListItems. Do not instantiate the store in ReadingList for iOS. BUG=686402 Review-Url: https://codereview.chromium.org/2667533003 Cr-Commit-Position: refs/heads/master@{#447551} Committed: https://chromium.googlesource.com/chromium/src/+/b227a4e9a84a3faae02a125085a49906e1b4c54a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -24 lines) Patch
M components/dom_distiller/core/dom_distiller_service.cc View 8 chunks +19 lines, -9 lines 0 comments Download
M ios/chrome/browser/dom_distiller/dom_distiller_service_factory.cc View 2 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Olivier
3 years, 10 months ago (2017-01-30 08:52:01 UTC) #2
Olivier
Ping
3 years, 10 months ago (2017-02-01 06:32:30 UTC) #3
wychen
The concept looks good. I haven't built and tested this CL though.
3 years, 10 months ago (2017-02-01 07:32:02 UTC) #6
Olivier
On 2017/02/01 07:32:02, wychen (APAC time zone) wrote: > The concept looks good. I haven't ...
3 years, 10 months ago (2017-02-01 08:02:54 UTC) #7
wychen
lgtm
3 years, 10 months ago (2017-02-01 08:04:30 UTC) #8
noyau (Ping after 24h)
lgtm
3 years, 10 months ago (2017-02-01 17:38:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667533003/1
3 years, 10 months ago (2017-02-01 17:39:03 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 17:44:51 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b227a4e9a84a3faae02a125085a4...

Powered by Google App Engine
This is Rietveld 408576698