Moved overflow-x and overflow-y to be generated in ComputedStyleBase.

Moved overflow-x and overflow-y to be generated in ComputedStyleBase.

Move the property overflow-x and overflow-y to be generated in
ComputedStyleBase. Both properties share the same enum type, which is
generated in ComputedStyleBaseConstants. Also moved getter / setter /
initial value methods to be generated in ComputedStyleBase.

BUG=628043
Review-Url: https://codereview.chromium.org/2673533002
Cr-Commit-Position: refs/heads/master@{#449499}
Committed: https://chromium.googlesource.com/chromium/src/+/7b2c17a81e500d85c26b4836eb88c62095b6f109

[shend, 2017-02-02 01:31:22]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 01:32:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 01:35:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 01:35:47]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shend, 2017-02-02 06:13:09]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-02-02 06:13:10]

Hi Naina, PTAL :)

[nainar, 2017-02-02 06:17:56]

lgtm

[shend, 2017-02-02 06:18:51]

shend@chromium.org changed reviewers:
+ sashab@chromium.org

[shend, 2017-02-02 06:18:52]

Hi Sasha PTAL

[shend, 2017-02-02 06:55:22]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 06:55:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 09:14:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 09:14:02]

Dry run: This issue passed the CQ dry run.

[sashab, 2017-02-03 05:05:23]

https://codereview.chromium.org/2673533002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSProperties.json5 (right):

https://codereview.chromium.org/2673533002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSProperties.json5:1362: ],
type_name: EOverflow

https://codereview.chromium.org/2673533002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSProperties.json5:1371: ],
type_name: EOverflow

[shend, 2017-02-03 05:27:21]

On 2017/02/03 at 05:05:23, sashab wrote:
>
https://codereview.chromium.org/2673533002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/css/CSSProperties.json5 (right):
> 
>
https://codereview.chromium.org/2673533002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/css/CSSProperties.json5:1362: ],
> type_name: EOverflow
> 
>
https://codereview.chromium.org/2673533002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/css/CSSProperties.json5:1371: ],
> type_name: EOverflow

lol not sure if I understood your comment correctly, but type_name was actually
already in the code for some reason (see the line below).

[haraken, 2017-02-03 07:44:40]

LGTM, this looks nicer!

[sashab, 2017-02-03 20:06:20]

sashab@chromium.org changed reviewers:
+ haraken@chromium.org

[sashab, 2017-02-03 20:06:21]

Oh my god it was literally the next line. That is amazing. LOL how did I do
that, get some sleep sasha

LGTM ha ha ha

[shend, 2017-02-08 22:04:11]

The CQ bit was checked by shend@chromium.org

[shend, 2017-02-08 22:04:11]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org
Link to the patchset: https://codereview.chromium.org/2673533002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-08 22:05:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 00:27:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 00:27:58]

Failed to apply patch for
third_party/WebKit/Source/core/style/ComputedStyle.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/style/ComputedStyle.cpp:367
  error: third_party/WebKit/Source/core/style/ComputedStyle.cpp: patch does not
apply

Patch:       third_party/WebKit/Source/core/style/ComputedStyle.cpp
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index
deca619c92323d67c5a079fac53e1d3860d8f849..b4f9aefc1e6f8baecbfd1560b199d1390e57aadd
100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -367,8 +367,6 @@ void ComputedStyle::copyNonInheritedFromCached(const
ComputedStyle& other) {
       other.m_nonInheritedData.m_effectiveDisplay;
   m_nonInheritedData.m_originalDisplay =
       other.m_nonInheritedData.m_originalDisplay;
-  m_nonInheritedData.m_overflowX = other.m_nonInheritedData.m_overflowX;
-  m_nonInheritedData.m_overflowY = other.m_nonInheritedData.m_overflowY;
   m_nonInheritedData.m_verticalAlign =
other.m_nonInheritedData.m_verticalAlign;
   m_nonInheritedData.m_position = other.m_nonInheritedData.m_position;
   m_nonInheritedData.m_tableLayout = other.m_nonInheritedData.m_tableLayout;
@@ -812,8 +810,7 @@ bool ComputedStyle::diffNeedsFullLayoutAndPaintInvalidation(
       getWritingMode() != other.getWritingMode())
     return true;
 
-  if (m_nonInheritedData.m_overflowX != other.m_nonInheritedData.m_overflowX ||
-      m_nonInheritedData.m_overflowY != other.m_nonInheritedData.m_overflowY ||
+  if (overflowX() != other.overflowX() || overflowY() != other.overflowY() ||
       clear() != other.clear() || getUnicodeBidi() != other.getUnicodeBidi() ||
       floating() != other.floating() ||
       m_nonInheritedData.m_originalDisplay !=

[shend, 2017-02-09 23:12:47]

The CQ bit was checked by shend@chromium.org

[shend, 2017-02-09 23:12:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, nainar@chromium.org, sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2673533002/#ps40001
(title: "Rebase?")

[commit-bot: I haz the power, 2017-02-09 23:13:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 01:04:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486681967751940,
"parent_rev": "ba52edd083f1ab24615082c9cd0d9834ed5db206", "commit_rev":
"7b2c17a81e500d85c26b4836eb88c62095b6f109"}

[commit-bot: I haz the power, 2017-02-10 01:05:51]

Description was changed from

==========
Moved overflow-x and overflow-y to be generated in ComputedStyleBase.

Move the property overflow-x and overflow-y to be generated in
ComputedStyleBase. Both properties share the same enum type, which is
generated in ComputedStyleBaseConstants. Also moved getter / setter /
initial value methods to be generated in ComputedStyleBase.

BUG=628043
==========

to

==========
Moved overflow-x and overflow-y to be generated in ComputedStyleBase.

Move the property overflow-x and overflow-y to be generated in
ComputedStyleBase. Both properties share the same enum type, which is
generated in ComputedStyleBaseConstants. Also moved getter / setter /
initial value methods to be generated in ComputedStyleBase.

BUG=628043

Review-Url: https://codereview.chromium.org/2673533002
Cr-Commit-Position: refs/heads/master@{#449499}
Committed:
https://chromium.googlesource.com/chromium/src/+/7b2c17a81e500d85c26b4836eb88...
==========

[commit-bot: I haz the power, 2017-02-10 01:05:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7b2c17a81e500d85c26b4836eb88...