Support generating enums shared by multiple ComputedStyle fields.

Support generating enums shared by multiple ComputedStyle fields.

When we generate fields in ComputedStyleBase, we generate both a new
enum type and a corresponding member variable with that type. So every
generated enum can only have one corresponding member. Unfortunately,
there are some enums (like EOverflow) that are shared by several
members.

The current solution is to explicitly specify the type_name flag, which
allows multiple fields to have the same enum type name. However, the
script currently will break if there's two fields with the same name
but different keywords.

This patch prevents such name conflicts by checking that enums with the
same name have the exact same keywords.

This is prework for generating the overflow-x and overflow-y fields
in ComputedStyle.

BUG=628043
Review-Url: https://codereview.chromium.org/2669973002
Cr-Commit-Position: refs/heads/master@{#448926}
Committed: https://chromium.googlesource.com/chromium/src/+/b66eb61f525f914b1b478b56e7b4792db7b4c4e5

[shend, 2017-02-02 01:44:32]

Description was changed from

==========
Support generating enums shared by multiple ComputedStyle fields.

When we generate fields in ComputedStyleBase, we generate both a new
enum type and a corresponding member variable with that type. So every
generated enum can only have one corresponding member. Unfortunately,
there are some enums (like EOverflow) that are shared by several
members.

The current solution is to explicitly specify the type_name flag, which
allows multiple fields to have the same enum type name. However, this
breaks make_computed_style_base.py since it will generate the same enum
twice, causing a name conflict in the generated code.

This patch ensures that duplicate enums are generated only once. It also
checks that enums with the same name have the exact same keywords.

This is prework for generating the overflow-x and overflow-y fields
in ComputedStyle.

BUG=628043
==========

to

==========
Support generating enums shared by multiple ComputedStyle fields.

When we generate fields in ComputedStyleBase, we generate both a new
enum type and a corresponding member variable with that type. So every
generated enum can only have one corresponding member. Unfortunately,
there are some enums (like EOverflow) that are shared by several
members.

The current solution is to explicitly specify the type_name flag, which
allows multiple fields to have the same enum type name. However, the
script currently will break if there's two fields with the same name
but different keywords.

This patch prevents such name conflicts by checking that enums with the
same name have the exact same keywords.

This is prework for generating the overflow-x and overflow-y fields
in ComputedStyle.

BUG=628043
==========

[shend, 2017-02-02 03:14:22]

shend@chromium.org changed reviewers:
+ bugsnash@chromium.org

[shend, 2017-02-02 03:14:23]

Hi Bugs, PTAL

[Bugs Nash, 2017-02-03 23:16:14]

lgtm

[shend, 2017-02-06 00:36:38]

shend@chromium.org changed reviewers:
+ sashab@chromium.org

[shend, 2017-02-06 00:36:39]

Hi Sasha, PTAL

[sashab, 2017-02-07 02:59:27]

Great CL description. Love that this functionality is already implemented and we
just need the check XD! LGTM

https://codereview.chromium.org/2669973002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):

https://codereview.chromium.org/2669973002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:95: ("'{}'
can't have type_name '{}' ".format(property_['name'], enum_name) +
Can you just use + property['name'] and + enum_name, might look simpler

[shend, 2017-02-07 21:44:02]

https://codereview.chromium.org/2669973002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):

https://codereview.chromium.org/2669973002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:95: ("'{}'
can't have type_name '{}' ".format(property_['name'], enum_name) +
On 2017/02/07 at 02:59:27, sashab wrote:
> Can you just use + property['name'] and + enum_name, might look simpler

done.

[shend, 2017-02-08 05:27:20]

The CQ bit was checked by shend@chromium.org

[shend, 2017-02-08 05:27:21]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2669973002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2017-02-08 05:27:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 07:01:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486531640396870,
"parent_rev": "3115871d52075f67487be67483412aad080ad1d6", "commit_rev":
"b66eb61f525f914b1b478b56e7b4792db7b4c4e5"}

[commit-bot: I haz the power, 2017-02-08 07:02:58]

Description was changed from

==========
Support generating enums shared by multiple ComputedStyle fields.

When we generate fields in ComputedStyleBase, we generate both a new
enum type and a corresponding member variable with that type. So every
generated enum can only have one corresponding member. Unfortunately,
there are some enums (like EOverflow) that are shared by several
members.

The current solution is to explicitly specify the type_name flag, which
allows multiple fields to have the same enum type name. However, the
script currently will break if there's two fields with the same name
but different keywords.

This patch prevents such name conflicts by checking that enums with the
same name have the exact same keywords.

This is prework for generating the overflow-x and overflow-y fields
in ComputedStyle.

BUG=628043
==========

to

==========
Support generating enums shared by multiple ComputedStyle fields.

When we generate fields in ComputedStyleBase, we generate both a new
enum type and a corresponding member variable with that type. So every
generated enum can only have one corresponding member. Unfortunately,
there are some enums (like EOverflow) that are shared by several
members.

The current solution is to explicitly specify the type_name flag, which
allows multiple fields to have the same enum type name. However, the
script currently will break if there's two fields with the same name
but different keywords.

This patch prevents such name conflicts by checking that enums with the
same name have the exact same keywords.

This is prework for generating the overflow-x and overflow-y fields
in ComputedStyle.

BUG=628043

Review-Url: https://codereview.chromium.org/2669973002
Cr-Commit-Position: refs/heads/master@{#448926}
Committed:
https://chromium.googlesource.com/chromium/src/+/b66eb61f525f914b1b478b56e7b4...
==========

[commit-bot: I haz the power, 2017-02-08 07:03:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b66eb61f525f914b1b478b56e7b4...