Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2673513003: dart2js: Introduce HGetLength to replace strange use of HFieldGet (Closed)

Created:
3 years, 10 months ago by sra1
Modified:
3 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Introduce HGetLength to replace strange use of HFieldGet Adding the new instruction lets HFieldGet have a [FieldEntity] element. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/a2ba9abbcc94f68423b7c2df823d789b446ab048

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -68 lines) Patch
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 3 chunks +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 3 chunks +8 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 7 chunks +34 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 9 chunks +53 lines, -37 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa_tracer.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/value_range_analyzer.dart View 1 chunk +5 lines, -6 lines 1 comment Download

Messages

Total messages: 7 (4 generated)
sra1
3 years, 10 months ago (2017-02-02 01:08:07 UTC) #4
Johnni Winther
lgtm https://codereview.chromium.org/2673513003/diff/20001/pkg/compiler/lib/src/ssa/value_range_analyzer.dart File pkg/compiler/lib/src/ssa/value_range_analyzer.dart (left): https://codereview.chromium.org/2673513003/diff/20001/pkg/compiler/lib/src/ssa/value_range_analyzer.dart#oldcode701 pkg/compiler/lib/src/ssa/value_range_analyzer.dart:701: if (!fieldGet.isInteger(closedWorld)) return info.newUnboundRange(); Why is this case ...
3 years, 10 months ago (2017-02-02 08:33:36 UTC) #5
sra1
3 years, 10 months ago (2017-02-02 21:00:25 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) manually as
a2ba9abbcc94f68423b7c2df823d789b446ab048 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698