Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 2673513003: dart2js: Introduce HGetLength to replace strange use of HFieldGet (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index ec83c92a50d1665705d904cb21b480c6788bd783..17fa53311dccbcec414627427e4bb39eefcbdcf6 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -5482,9 +5482,7 @@ class SsaBuilder extends ast.Visitor
HInstruction originalLength = null; // Set for growable lists.
HInstruction buildGetLength() {
- MemberElement lengthElement = helpers.jsIndexableLength;
- HFieldGet result = new HFieldGet(
- lengthElement, array, commonMasks.positiveIntType,
+ HInstruction result = new HGetLength(array, commonMasks.positiveIntType,
isAssignable: !isFixed);
add(result);
return result;
« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/builder_kernel.dart » ('j') | pkg/compiler/lib/src/ssa/value_range_analyzer.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698