Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: pkg/compiler/lib/src/ssa/ssa_tracer.dart

Issue 2673513003: dart2js: Introduce HGetLength to replace strange use of HFieldGet (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library ssa.tracer; 5 library ssa.tracer;
6 6
7 import 'dart:async' show EventSink; 7 import 'dart:async' show EventSink;
8 8
9 import '../diagnostics/invariant.dart' show DEBUG_MODE; 9 import '../diagnostics/invariant.dart' show DEBUG_MODE;
10 import '../js_backend/namer.dart' show Namer; 10 import '../js_backend/namer.dart' show Namer;
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 if (node.isAssignOp) { 231 if (node.isAssignOp) {
232 String valueId = temporaryId(node.value); 232 String valueId = temporaryId(node.value);
233 return 'ReadModifyWrite: $receiverId.$fieldName $op= $valueId'; 233 return 'ReadModifyWrite: $receiverId.$fieldName $op= $valueId';
234 } else if (node.isPreOp) { 234 } else if (node.isPreOp) {
235 return 'ReadModifyWrite: $op$receiverId.$fieldName'; 235 return 'ReadModifyWrite: $op$receiverId.$fieldName';
236 } else { 236 } else {
237 return 'ReadModifyWrite: $receiverId.$fieldName$op'; 237 return 'ReadModifyWrite: $receiverId.$fieldName$op';
238 } 238 }
239 } 239 }
240 240
241 String visitGetLength(HGetLength node) {
242 return 'GetLength: ${temporaryId(node.receiver)}';
243 }
244
241 String visitLocalGet(HLocalGet node) { 245 String visitLocalGet(HLocalGet node) {
242 String localName = node.variable.name; 246 String localName = node.variable.name;
243 return 'LocalGet: ${temporaryId(node.local)}.$localName'; 247 return 'LocalGet: ${temporaryId(node.local)}.$localName';
244 } 248 }
245 249
246 String visitLocalSet(HLocalSet node) { 250 String visitLocalSet(HLocalSet node) {
247 String valueId = temporaryId(node.value); 251 String valueId = temporaryId(node.value);
248 String localName = node.variable.name; 252 String localName = node.variable.name;
249 return 'LocalSet: ${temporaryId(node.local)}.$localName to $valueId'; 253 return 'LocalSet: ${temporaryId(node.local)}.$localName to $valueId';
250 } 254 }
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
556 } 560 }
557 561
558 String visitAwait(HAwait node) { 562 String visitAwait(HAwait node) {
559 return "Await: ${temporaryId(node.inputs[0])}"; 563 return "Await: ${temporaryId(node.inputs[0])}";
560 } 564 }
561 565
562 String visitYield(HYield node) { 566 String visitYield(HYield node) {
563 return "Yield${node.hasStar ? "*" : ""}: ${temporaryId(node.inputs[0])}"; 567 return "Yield${node.hasStar ? "*" : ""}: ${temporaryId(node.inputs[0])}";
564 } 568 }
565 } 569 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698