Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: slave/skia_slave_scripts/run_decoding_tests.py

Issue 26734006: Changes needed to rebaseline skimage with rebaseline.py. (Closed) Base URL: https://skia.googlecode.com/svn/buildbot
Patch Set: Respond to comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « slave/skia_slave_scripts/prerender.py ('k') | slave/skia_slave_scripts/upload_skimage_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: slave/skia_slave_scripts/run_decoding_tests.py
diff --git a/slave/skia_slave_scripts/run_decoding_tests.py b/slave/skia_slave_scripts/run_decoding_tests.py
index 472d5ec61bb99f128863d25b545a975315b99f60..9f0468ed4d642b36a5f82746c89df474ee649d9b 100644
--- a/slave/skia_slave_scripts/run_decoding_tests.py
+++ b/slave/skia_slave_scripts/run_decoding_tests.py
@@ -5,32 +5,34 @@
""" Run the Skia skimage executable. """
-from build_step import BuildStep, BuildStepFailure
+from build_step import BuildStep, BuildStepFailure, GM_EXPECTATIONS_FILENAME
# builder_name_schema must be imported after build_step so the PYTHONPATH will
# be set properly to import it.
import builder_name_schema
+import run_gm
import sys
class RunDecodingTests(BuildStep):
def _Run(self):
cmd = ['-r', self._device_dirs.SKImageInDir(), '--noreencode']
- expectations_name = (builder_name_schema.GetWaterfallBot(self._builder_name)
- + '.json')
+ subdir = builder_name_schema.GetWaterfallBot(self._builder_name)
# Read expectations, which were downloaded/copied to the device.
expectations_file = self._flavor_utils.DevicePathJoin(
- self._device_dirs.SKImageExpectedDir(),
- expectations_name)
+ self._device_dirs.SKImageExpectedDir(), subdir,
+ GM_EXPECTATIONS_FILENAME)
have_expectations = self._flavor_utils.DevicePathExists(expectations_file)
if have_expectations:
cmd.extend(['--readExpectationsPath', expectations_file])
# Write the expectations file, in case any did not match.
+ device_subdir = self._flavor_utils.DevicePathJoin(
+ self._device_dirs.SKImageOutDir(), subdir)
+ self._flavor_utils.CreateCleanDeviceDirectory(device_subdir)
output_expectations_file = self._flavor_utils.DevicePathJoin(
- self._device_dirs.SKImageOutDir(),
- expectations_name)
+ device_subdir, run_gm.JSON_SUMMARY_FILENAME)
cmd.extend(['--createExpectationsPath', output_expectations_file])
« no previous file with comments | « slave/skia_slave_scripts/prerender.py ('k') | slave/skia_slave_scripts/upload_skimage_results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698