Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: slave/skia_slave_scripts/upload_skimage_results.py

Issue 26734006: Changes needed to rebaseline skimage with rebaseline.py. (Closed) Base URL: https://skia.googlecode.com/svn/buildbot
Patch Set: Respond to comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « slave/skia_slave_scripts/run_decoding_tests.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: slave/skia_slave_scripts/upload_skimage_results.py
diff --git a/slave/skia_slave_scripts/upload_skimage_results.py b/slave/skia_slave_scripts/upload_skimage_results.py
index fa0d7308865bca14c8cbfab412614155546a4c07..c95075a4fc7c9a865110ec7eb46e19e7d41000a7 100644
--- a/slave/skia_slave_scripts/upload_skimage_results.py
+++ b/slave/skia_slave_scripts/upload_skimage_results.py
@@ -5,7 +5,9 @@
"""Upload results from running skimage."""
+import os
import posixpath
+import skia_vars
import sys
from utils import gs_utils
@@ -42,7 +44,26 @@ class UploadSKImageResults(BuildStep):
def _Run(self):
if self._do_upload_results:
+ # Copy actual-results.json to skimage/output/actuals
+ print '\n\n====Uploading skimage actual-results to Google Storage====\n\n'
+ src_dir = os.path.abspath(os.path.join(self._skimage_out_dir,
+ self._builder_name))
+ dest_dir = posixpath.join(
+ skia_vars.GetGlobalVariable('googlestorage_bucket'),
+ 'skimage', 'actuals', self._builder_name)
+ http_header_lines = ['Cache-Control:public,max-age=3600']
+ gs_utils.CopyStorageDirectory(src_dir=src_dir,
+ dest_dir=dest_dir,
+ gs_acl='public-read',
+ http_header_lines=http_header_lines)
+
# Copy actual images and expectations to Google Storage.
+ # TODO(scroggo): This step uploads both the expectations and the
+ # mismatches, even though the expectations files were already uploaded
+ # in the above step. Once skimage is rewritten to include the hash digest
+ # in the filename, rewrite this to upload a folder (named <input image>)
+ # containing the result (named <hash digest>.png), much like
+ # upload_gm_results.
print '\n\n========Uploading skimage results to Google Storage=======\n\n'
relative_dir = posixpath.join('skimage', 'output', self._builder_name)
gs_utils.UploadDirectoryContentsIfChanged(
« no previous file with comments | « slave/skia_slave_scripts/run_decoding_tests.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698