Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: slave/skia_slave_scripts/prerender.py

Issue 26734006: Changes needed to rebaseline skimage with rebaseline.py. (Closed) Base URL: https://skia.googlecode.com/svn/buildbot
Patch Set: Respond to comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | slave/skia_slave_scripts/run_decoding_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: slave/skia_slave_scripts/prerender.py
diff --git a/slave/skia_slave_scripts/prerender.py b/slave/skia_slave_scripts/prerender.py
index 658c1f8ff22f5011b7db79e65d405a9ad9065645..1f38eb1a66b08236ce8319156074915846aa6ace 100644
--- a/slave/skia_slave_scripts/prerender.py
+++ b/slave/skia_slave_scripts/prerender.py
@@ -47,15 +47,19 @@ class PreRender(BuildStep):
# Copy expectations file and images to decode in skimage to device.
self._flavor_utils.CreateCleanDeviceDirectory(
self._device_dirs.SKImageExpectedDir())
- skimage_expected_filename = builder_name_schema.GetWaterfallBot(
- self._builder_name) + ".json"
+ skimage_subdir = builder_name_schema.GetWaterfallBot(self._builder_name)
+ skimage_expected_filename = build_step.GM_EXPECTATIONS_FILENAME
skimage_host_expectations = os.path.join(self._skimage_expected_dir,
+ skimage_subdir,
skimage_expected_filename)
if os.path.exists(skimage_host_expectations):
+ skimage_device_subdir = self._flavor_utils.DevicePathJoin(
+ self._device_dirs.SKImageExpectedDir(),
+ skimage_subdir)
skimage_device_expectations = self._flavor_utils.DevicePathJoin(
- self._device_dirs.SKImageExpectedDir(), skimage_expected_filename)
+ skimage_device_subdir, skimage_expected_filename)
# For builders without an attached device, PushFileToDevice will fail
# when attempting to copy a file to itself. In this case, there is no
# need to copy. Only do the push when there is an attached device,
@@ -64,6 +68,8 @@ class PreRender(BuildStep):
# https://code.google.com/p/skia/issues/detail?id=1571 is fixed, this
# check can go away.
if skimage_device_expectations != skimage_host_expectations:
+ # Create the subdir on the device.
+ self._flavor_utils.CreateCleanDeviceDirectory(skimage_device_subdir)
self._flavor_utils.PushFileToDevice(skimage_host_expectations,
skimage_device_expectations)
« no previous file with comments | « no previous file | slave/skia_slave_scripts/run_decoding_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698