Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2673043002: Revert of Add main lib section sizes to resource_sizes.py. (Closed)

Created:
3 years, 10 months ago by estevenson
Modified:
3 years, 10 months ago
Reviewers:
pkotwicz, agrieve, Torne
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add main lib section sizes to resource_sizes.py. (patchset #5 id:80001 of https://codereview.chromium.org/2675703003/ ) Reason for revert: Breaks some Cronet builders because their native lib has different sections: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARM64%20Builder/builds/48257 Original issue's description: > Add main lib section sizes to resource_sizes.py. > > This CL adds detailed metrics for the main native library section sizes, > grouped into "text", "data", "relocations", "unwind", "symbols", and > "other" sections. These categories are added under a new subtest: > "_MainLibInfo". > > BUG=681153 > > Review-Url: https://codereview.chromium.org/2675703003 > Cr-Commit-Position: refs/heads/master@{#447991} > Committed: https://chromium.googlesource.com/chromium/src/+/51583da63dae5f4c3baa9a229160b2c027afffb4 TBR=agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=681153 TBR=agrieve@chromium.org Review-Url: https://codereview.chromium.org/2673043002 Cr-Commit-Position: refs/heads/master@{#447999} Committed: https://chromium.googlesource.com/chromium/src/+/9f800ec0044b9c7c7c88553f406cc5e146e72516

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -50 lines) Patch
M build/android/resource_sizes.py View 3 chunks +0 lines, -50 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
estevenson
Created Revert of Add main lib section sizes to resource_sizes.py.
3 years, 10 months ago (2017-02-03 15:00:23 UTC) #1
estevenson
+Sheriffs
3 years, 10 months ago (2017-02-03 15:01:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673043002/1
3 years, 10 months ago (2017-02-03 15:08:20 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 15:09:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9f800ec0044b9c7c7c88553f406c...

Powered by Google App Engine
This is Rietveld 408576698