Add main lib section sizes to resource_sizes.py.

Add main lib section sizes to resource_sizes.py.

This CL adds detailed metrics for the main native library section sizes,
grouped into "text", "data", "relocations", "unwind", "symbols", and
"other" sections. These categories are added under a new subtest:
"_MainLibInfo".

BUG=681153
Review-Url: https://codereview.chromium.org/2675703003
Cr-Commit-Position: refs/heads/master@{#447991}
Committed: https://chromium.googlesource.com/chromium/src/+/51583da63dae5f4c3baa9a229160b2c027afffb4

[estevenson, 2017-02-02 19:11:11]

estevenson@chromium.org changed reviewers:
+ agrieve@chromium.org

[estevenson, 2017-02-02 19:11:11]

ptal Andrew!

[agrieve, 2017-02-02 19:45:42]

https://codereview.chromium.org/2675703003/diff/20001/build/android/resource_...
File build/android/resource_sizes.py (right):

https://codereview.chromium.org/2675703003/diff/20001/build/android/resource_...
build/android/resource_sizes.py:109: 'other': ['hash', 'init_array',
'fini_array', 'comment',
I don't think the list of sections is guaranteed to not change over time.
I think it would be better to make these "other" sections a comment, and parse
in a way that puts things that don't match anything above in the "other" bucket.

re.finditer() should do the trick.

[estevenson, 2017-02-02 21:34:54]

ptal Andrew

https://codereview.chromium.org/2675703003/diff/20001/build/android/resource_...
File build/android/resource_sizes.py (right):

https://codereview.chromium.org/2675703003/diff/20001/build/android/resource_...
build/android/resource_sizes.py:109: 'other': ['hash', 'init_array',
'fini_array', 'comment',
On 2017/02/02 19:45:41, agrieve wrote:
> I don't think the list of sections is guaranteed to not change over time.
> I think it would be better to make these "other" sections a comment, and parse
> in a way that puts things that don't match anything above in the "other"
bucket.
> 
> re.finditer() should do the trick.

True! I actually meant to do something like that because I noticed when running
readelf locally that I saw one less section than you posted in
https://bugs.chromium.org/p/chromium/issues/detail?id=681153. Done.

[agrieve, 2017-02-02 21:41:44]

lgtm

https://codereview.chromium.org/2675703003/diff/40001/build/android/resource_...
File build/android/resource_sizes.py (right):

https://codereview.chromium.org/2675703003/diff/40001/build/android/resource_...
build/android/resource_sizes.py:103: _READELF_EXCLUDED_SECTIONS = ['.bss']
nit: I'm not sure why I suggested not including this. We should include it (in
it's own section).

[estevenson, 2017-02-02 22:05:00]

The CQ bit was checked by estevenson@chromium.org

[estevenson, 2017-02-02 22:05:01]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2675703003/#ps80001
(title: "Remove _READELF_EXCLUDED_SECTIONS")

[commit-bot: I haz the power, 2017-02-02 22:05:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 00:10:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 00:10:47]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[estevenson, 2017-02-03 13:11:22]

The CQ bit was checked by estevenson@chromium.org

[commit-bot: I haz the power, 2017-02-03 13:14:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 14:36:01]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486127482264840,
"parent_rev": "1d6d5d29921ee1e7cc9c6ce11187bc8ccb11d8f3", "commit_rev":
"51583da63dae5f4c3baa9a229160b2c027afffb4"}

[commit-bot: I haz the power, 2017-02-03 14:36:35]

Description was changed from

==========
Add main lib section sizes to resource_sizes.py.

This CL adds detailed metrics for the main native library section sizes,
grouped into "text", "data", "relocations", "unwind", "symbols", and
"other" sections. These categories are added under a new subtest:
"_MainLibInfo".

BUG=681153
==========

to

==========
Add main lib section sizes to resource_sizes.py.

This CL adds detailed metrics for the main native library section sizes,
grouped into "text", "data", "relocations", "unwind", "symbols", and
"other" sections. These categories are added under a new subtest:
"_MainLibInfo".

BUG=681153

Review-Url: https://codereview.chromium.org/2675703003
Cr-Commit-Position: refs/heads/master@{#447991}
Committed:
https://chromium.googlesource.com/chromium/src/+/51583da63dae5f4c3baa9a229160...
==========

[commit-bot: I haz the power, 2017-02-03 14:36:37]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/51583da63dae5f4c3baa9a229160...

[estevenson, 2017-02-03 15:00:23]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2673043002/ by estevenson@chromium.org.

The reason for reverting is: Breaks some Cronet builders because their native
lib has different sections:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARM....