Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2673003003: Rename MostVisited ui bits to Tile(Grid). (Closed)

Created:
3 years, 10 months ago by Michael van Ouwerkerk
Modified:
3 years, 10 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename MostVisited ui bits to Tile(Grid). * ntp.MostVisitedLayout -> suggestions.TileGridLayout * ntp.MostVisitedItemView -> suggestions.TileView * Associated resource names for dimensions, ids, templates * Snackbar cleanup in destroy() that I had missed in the refactor. BUG=677672 Review-Url: https://codereview.chromium.org/2673003003 Cr-Commit-Position: refs/heads/master@{#448599} Committed: https://chromium.googlesource.com/chromium/src/+/9fc90612e0bf684874654a270183e4a07069a2cf

Patch Set 1 #

Patch Set 2 : Cleanups. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -501 lines) Patch
D chrome/android/java/res/drawable-v21/most_visited_item_highlight.xml View 1 chunk +0 lines, -14 lines 0 comments Download
A + chrome/android/java/res/drawable-v21/tile_view_highlight.xml View 1 chunk +1 line, -1 line 0 comments Download
D chrome/android/java/res/drawable/most_visited_item_highlight.xml View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/android/java/res/drawable/most_visited_item_highlight_mask.xml View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/android/java/res/drawable/most_visited_item_highlight_plain.xml View 1 chunk +0 lines, -12 lines 0 comments Download
A + chrome/android/java/res/drawable/tile_view_highlight.xml View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/java/res/drawable/tile_view_highlight_mask.xml View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/java/res/drawable/tile_view_highlight_plain.xml View 1 chunk +1 line, -1 line 0 comments Download
D chrome/android/java/res/layout/most_visited_item.xml View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/android/java/res/layout/most_visited_placeholder.xml View 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/android/java/res/layout/new_tab_page_layout.xml View 1 chunk +8 lines, -8 lines 0 comments Download
A + chrome/android/java/res/layout/new_tab_page_tile_grid_placeholder.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/android/java/res/layout/suggestions_site_tile_grid.xml View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/android/java/res/layout/tile_view.xml View 3 chunks +15 lines, -15 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 1 chunk +11 lines, -11 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItemView.java View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedLayout.java View 1 chunk +0 lines, -154 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 2 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java View 1 9 chunks +14 lines, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 1 2 11 chunks +31 lines, -31 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java View 2 chunks +2 lines, -3 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGridLayout.java View 5 chunks +13 lines, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroupDelegateImpl.java View 1 chunk +3 lines, -0 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileView.java View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/MainActivityWithURLTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java View 7 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
3 years, 10 months ago (2017-02-03 18:07:31 UTC) #6
Bernhard Bauer
LGTM!
3 years, 10 months ago (2017-02-07 10:09:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673003003/60001
3 years, 10 months ago (2017-02-07 10:22:47 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 11:19:31 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9fc90612e0bf684874654a270183...

Powered by Google App Engine
This is Rietveld 408576698