chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java - Issue 2673003003: Rename MostVisited ui bits to Tile(Grid).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2673003003: Rename MostVisited ui bits to Tile(Grid). (Closed)

Patch Set: Rebase. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedLayout.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

index 0e5e08b5dba7c4a0ca902a9b33575853c09a27ec..403c496f3199b287b61dd7653a501cd056c5598f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

@@ -41,7 +41,6 @@ import org.chromium.chrome.browser.ntp.snippets.SuggestionsSource;

import org.chromium.chrome.browser.profiles.Profile;

import org.chromium.chrome.browser.search_engines.TemplateUrlService;

import org.chromium.chrome.browser.search_engines.TemplateUrlService.TemplateUrlServiceObserver;

-import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;

import org.chromium.chrome.browser.suggestions.SuggestionsMetricsReporter;

import org.chromium.chrome.browser.suggestions.SuggestionsNavigationDelegate;

import org.chromium.chrome.browser.suggestions.SuggestionsNavigationDelegateImpl;

@@ -102,7 +101,6 @@ public class NewTabPage

private final TileGroup.Delegate mTileGroupDelegate;

private TabObserver mTabObserver;

- private SnackbarController mMostVisitedItemRemovedController;

private LogoBridge mLogoBridge;

private boolean mSearchProviderHasLogo;

private String mOnLogoClickUrl;

@@ -631,9 +629,6 @@ public class NewTabPage

mSnippetsBridge.destroy();

mSnippetsBridge = null;

}

- if (mMostVisitedItemRemovedController != null) {

- mTab.getSnackbarManager().dismissSnackbars(mMostVisitedItemRemovedController);

- }

mNewTabPageManager.onDestroy();

mTileGroupDelegate.destroy();

TemplateUrlService.getInstance().removeObserver(this);