Implements PrintBrowser mode.

Implements PrintBrowser mode.

Added --enable-print-browser runtime flag.

Renders the frame in print mode in response to the enable-print-browser
runtime flag.
Currently defaults to dimensions of A4 portrait paper and is set to show
background graphics.
This functionality is dependent on slimming paint v2, which is
automatically enabled if needed.

This can be invoked from the command line with:
content_shell --enable-print-browser "http://example.com"

The virtual test environment can be run using:
run-webkit-tests virtual/print_browser

Design doc: https://docs.google.com/document/d/1G2RoH7yiwh_vosEHsHTwqETBvt2ij8p9ov0D3kIz4ww/edit?usp=sharing
BUG=667547
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2672983003
Cr-Commit-Position: refs/heads/master@{#449585}
Committed: https://chromium.googlesource.com/chromium/src/+/080936f5193590e65409c60127a510f71e910d73

[gozzard, 2017-02-03 05:22:59]

Description was changed from

==========
Added --enable-print-browser runtime flag.

This flag is passed on to the renderer. The logic this flag enables is
in a separate, dependent CL.

Design doc:
https://docs.google.com/document/d/1G2RoH7yiwh_vosEHsHTwqETBvt2ij8p9ov0D3kIz4...
BUG=667547
==========

to

==========
Added --enable-print-browser runtime flag.

This flag is passed on to the renderer. The logic this flag enables is
in a separate, dependent CL (crrev.com/2671953002).

Design doc:
https://docs.google.com/document/d/1G2RoH7yiwh_vosEHsHTwqETBvt2ij8p9ov0D3kIz4...
BUG=667547
==========

[gozzard, 2017-02-03 05:31:55]

gozzard@google.com changed reviewers:
+ nainar@chromium.org

[gozzard, 2017-02-03 05:31:56]

PTAL

[gozzard, 2017-02-03 05:32:16]

The CQ bit was checked by gozzard@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 05:32:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-02-03 05:49:03]

lgtm

[gozzard, 2017-02-03 05:50:21]

gozzard@google.com changed reviewers:
+ creis@chromium.org, nasko@chromium.org

[gozzard, 2017-02-03 05:50:21]

PTAL

[commit-bot: I haz the power, 2017-02-03 09:14:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 09:14:34]

Dry run: This issue passed the CQ dry run.

[gozzard, 2017-02-07 00:57:51]

On 2017/02/03 at 05:50:21, gozzard wrote:
> PTAL

Bump.

Sorry to nag, @creis, @nasko, but I have 3 days left in my internship, so this
is becoming a little time sensitive. PTAL :)

[nasko, 2017-02-07 19:46:13]

Please merge the two CLs, as adding a feature flag with no difference in
behavior is undesirable. The dependent CL is not that bit to warrant separate
one and keeping them together is easier for code archeology.

https://codereview.chromium.org/2672983003/diff/1/content/public/common/conte...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/2672983003/diff/1/content/public/common/conte...
content/public/common/content_switches.cc:448: // Enables PrintBrowser mode, in
which everything renders as though printed
nit: End sentence with a period.

[gozzard, 2017-02-08 00:46:24]

Description was changed from

==========
Added --enable-print-browser runtime flag.

This flag is passed on to the renderer. The logic this flag enables is
in a separate, dependent CL (crrev.com/2671953002).

Design doc:
https://docs.google.com/document/d/1G2RoH7yiwh_vosEHsHTwqETBvt2ij8p9ov0D3kIz4...
BUG=667547
==========

to

==========
Added --enable-print-browser runtime flag.

This flag is passed on to the renderer. The logic this flag enables is
in a separate, dependent CL (crrev.com/2671953002).

Design doc:
https://docs.google.com/document/d/1G2RoH7yiwh_vosEHsHTwqETBvt2ij8p9ov0D3kIz4...
BUG=667547
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[gozzard, 2017-02-08 00:49:51]

Merged in crrev.com/2671953002 as per request.

Responded to comments from both that CL and this one.

PTAL.

https://codereview.chromium.org/2672983003/diff/1/content/public/common/conte...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/2672983003/diff/1/content/public/common/conte...
content/public/common/content_switches.cc:448: // Enables PrintBrowser mode, in
which everything renders as though printed
On 2017/02/07 at 19:46:13, nasko (very slow) wrote:
> nit: End sentence with a period.

Done.

[gozzard, 2017-02-08 00:53:08]

Description was changed from

==========
Added --enable-print-browser runtime flag.

This flag is passed on to the renderer. The logic this flag enables is
in a separate, dependent CL (crrev.com/2671953002).

Design doc:
https://docs.google.com/document/d/1G2RoH7yiwh_vosEHsHTwqETBvt2ij8p9ov0D3kIz4...
BUG=667547
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Implements PrintBrowser mode.

Added --enable-print-browser runtime flag.

Renders the frame in print mode in response to the enable-print-browser
runtime flag.
Currently defaults to dimensions of A4 portrait paper and is set to show
background graphics.
This functionality is dependent on slimming paint v2, which is
automatically enabled if needed.

This can be invoked from the command line with:
content_shell --enable-print-browser "http://example.com"

Design doc:
https://docs.google.com/document/d/1G2RoH7yiwh_vosEHsHTwqETBvt2ij8p9ov0D3kIz4...
BUG=667547
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[gozzard, 2017-02-08 00:54:22]

On 2017/02/08 at 00:49:51, gozzard wrote:
> Merged in crrev.com/2671953002 as per request.
> 
> Responded to comments from both that CL and this one.
> 
> PTAL.
> 
>
https://codereview.chromium.org/2672983003/diff/1/content/public/common/conte...
> File content/public/common/content_switches.cc (right):
> 
>
https://codereview.chromium.org/2672983003/diff/1/content/public/common/conte...
> content/public/common/content_switches.cc:448: // Enables PrintBrowser mode,
in which everything renders as though printed
> On 2017/02/07 at 19:46:13, nasko (very slow) wrote:
> > nit: End sentence with a period.
> 
> Done.

I forgot to mention: I am working on a LayoutTest for this feature now. I do not
believe there are any effective unit tests for this feature.

[gozzard, 2017-02-08 00:55:17]

gozzard@google.com changed reviewers:
+ bokan@chromium.org, mstensho@opera.com

[pdr., 2017-02-08 04:28:04]

pdr@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2017-02-08 04:28:05]

Cool feature! This will be useful for testing print bugs in blink too.

https://codereview.chromium.org/2672983003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2672983003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2933: if
(!m_frame->document()->printing()) {
Can you split this logic out into a helper? I think that will help keep
updateLifecyclePhasesInternal simple.

https://codereview.chromium.org/2672983003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2938: int pageWidth = 595,
pageHeight = 842;  // A4 Portrait
Nit: can you break these into constants?
Maybe "const int kA4PortraitPageWidth = 595;"

https://codereview.chromium.org/2672983003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2941: float height;
Do we need to do this print context and page rect computations and event
dispatching on every call to updateLifecyclePhasesInternal?

https://codereview.chromium.org/2672983003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:3115: if
(RuntimeEnabledFeatures::printBrowserEnabled())
WDYT about implementing this for both spv2 (as you've done here) and the spv1
codepaths? I think it should be pretty easy to do and will make sure this
feature isn't tied to spv2's timeline.

If you do this, please add a layouttest that covers both codepaths. The virtual
test infrastructure lets you write tests that run with a flag. It's a little
confusing so please ask if you need help with this.

[gozzard, 2017-02-08 05:40:20]

PTAL.

https://codereview.chromium.org/2672983003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2672983003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2933: if
(!m_frame->document()->printing()) {
On 2017/02/08 at 04:28:05, pdr. wrote:
> Can you split this logic out into a helper? I think that will help keep
updateLifecyclePhasesInternal simple.

Done.

https://codereview.chromium.org/2672983003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2938: int pageWidth = 595,
pageHeight = 842;  // A4 Portrait
On 2017/02/08 at 04:28:05, pdr. wrote:
> Nit: can you break these into constants?
> Maybe "const int kA4PortraitPageWidth = 595;"

Done.

https://codereview.chromium.org/2672983003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2941: float height;
On 2017/02/08 at 04:28:05, pdr. wrote:
> Do we need to do this print context and page rect computations and event
dispatching on every call to updateLifecyclePhasesInternal?

m_printContext->begin() indirectly sets m_frame->document()->printing() to be
true. As such this setup code will only runs as necessary.

https://codereview.chromium.org/2672983003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:3115: if
(RuntimeEnabledFeatures::printBrowserEnabled())
On 2017/02/08 at 04:28:05, pdr. wrote:
> WDYT about implementing this for both spv2 (as you've done here) and the spv1
codepaths? I think it should be pretty easy to do and will make sure this
feature isn't tied to spv2's timeline.

I had a look into this and found that it would require significantly more
boilerplate to implement support for SPV1. Therefore we made the design decision
to (at least initially) only support SPV2. This may no longer be the case after
changing to RuntimeEnabledFeatures::printBrowserEnabled(). I will look into it,
but I think this is best done as a separate CL, especially as I probably don't
have the time left in my internship to do this.

> If you do this, please add a layouttest that covers both codepaths. The
virtual test infrastructure lets you write tests that run with a flag. It's a
little confusing so please ask if you need help with this.

I just finished setting this up with a virtual test environment and an example
test anyway, actually.

[nasko, 2017-02-08 05:43:15]

content/ bits LGTM.

[gozzard, 2017-02-08 06:03:37]

The CQ bit was checked by gozzard@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 06:04:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-02-08 06:34:08]

I think this looks pretty reasonable. Is there a good owner for this code once
your internship ends?

https://codereview.chromium.org/2672983003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2672983003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2914:
dispatchEventsForPrintingOnAllFrames();
Could you use forAllNonThrottledFrameViews for this?

I.e.,
forAllNonThrottledFrameViews([](FrameView& frameView) {
  frameView.frame().document()->dispatchEventsForPrinting();
});

https://codereview.chromium.org/2672983003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2915: }
I think this approach can fail to dispatch print events if a subframe has not
yet loaded. For example, if we have a page with an iframe'd ad and we hit this
code before the ad loads, will we fail to ever dispatch the printing event to
the ad? If so, can you add a TODO(gozzard): comment mentioning this?

[commit-bot: I haz the power, 2017-02-08 07:48:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 07:48:51]

Dry run: This issue passed the CQ dry run.

[mstensho (USE GERRIT), 2017-02-08 14:32:29]

Just some nit-picking from me. pdr reported some real issues / concerns, so I'll
leave it to him to give a green light. :)

Looking forwards to this feature!

https://codereview.chromium.org/2672983003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2672983003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2905: if
(!m_frame->document()->printing()) {
Could consider an early return here; i.e.:

  if (m_frame->document()->printing())
    return;
  // The rest of the code goes here.

That at least used to be preferred Blink style.

https://codereview.chromium.org/2672983003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2919: if (m_printContext) {
Might even consider an early return on !m_printContext here.

https://codereview.chromium.org/2672983003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2961: }
No need for the curly braces.

[gozzard, 2017-02-09 04:17:26]

Thanks for all the feedback.

PTAL.

https://codereview.chromium.org/2672983003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2672983003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2905: if
(!m_frame->document()->printing()) {
On 2017/02/08 at 14:32:29, mstensho wrote:
> Could consider an early return here; i.e.:
> 
>   if (m_frame->document()->printing())
>     return;
>   // The rest of the code goes here.
> 
> That at least used to be preferred Blink style.

Done.

https://codereview.chromium.org/2672983003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2914:
dispatchEventsForPrintingOnAllFrames();
On 2017/02/08 at 06:34:08, pdr. wrote:
> Could you use forAllNonThrottledFrameViews for this?
> 
> I.e.,
> forAllNonThrottledFrameViews([](FrameView& frameView) {
>   frameView.frame().document()->dispatchEventsForPrinting();
> });

dispatchEventsForPrinting() ultimately informs some listeners of the media query
change and shuffles any print-related events down to our children. This will not
be run frequently, and seems inadvisable to skip, so we would want to apply this
for throttled FrameViews also. If there existed a forAllFrameViews() variant of
this helper function that may be appropriate, but it would be a simple thin
wrapper around this loop anyway, so I am not inclined to implement such a
helper.

https://codereview.chromium.org/2672983003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2915: }
On 2017/02/08 at 06:34:08, pdr. wrote:
> I think this approach can fail to dispatch print events if a subframe has not
yet loaded. For example, if we have a page with an iframe'd ad and we hit this
code before the ad loads, will we fail to ever dispatch the printing event to
the ad? If so, can you add a TODO(gozzard): comment mentioning this?

This appears to be the case. However, I believe this is expected behaviour. The
only endpoints I am aware of for the dispatchEvent() system are javascript
listeners. If the javascript has not yet loaded/executed, it should handle
checking the current state of the page itself, if it is interested. I believe it
is by design that this only notifies existing, registered listeners. Using
printing as an example: It simply triggers any registered MediaQueryList
listeners. The javascript must query for the current MediaQueryList state before
it can even register a listener. If there are any internal events, then they
should follow suit and check the current state on initialization.

https://codereview.chromium.org/2672983003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2919: if (m_printContext) {
On 2017/02/08 at 14:32:29, mstensho wrote:
> Might even consider an early return on !m_printContext here.

Done.

https://codereview.chromium.org/2672983003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2961: }
On 2017/02/08 at 14:32:29, mstensho wrote:
> No need for the curly braces.

Done.

[pdr., 2017-02-10 01:03:21]

LGTM.

Just a small note, you'll need to rebase because RuntimeEnabledFeatures.in has
evolved into RuntimeEnabledFeatures.json5.

Naina and the style/layout teams will own this code once Gozzard leaves so
please wait for a final LGTM from them since there have been a few changes.

[gozzard, 2017-02-10 01:25:55]

Description was changed from

==========
Implements PrintBrowser mode.

Added --enable-print-browser runtime flag.

Renders the frame in print mode in response to the enable-print-browser
runtime flag.
Currently defaults to dimensions of A4 portrait paper and is set to show
background graphics.
This functionality is dependent on slimming paint v2, which is
automatically enabled if needed.

This can be invoked from the command line with:
content_shell --enable-print-browser "http://example.com"

Design doc:
https://docs.google.com/document/d/1G2RoH7yiwh_vosEHsHTwqETBvt2ij8p9ov0D3kIz4...
BUG=667547
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Implements PrintBrowser mode.

Added --enable-print-browser runtime flag.

Renders the frame in print mode in response to the enable-print-browser
runtime flag.
Currently defaults to dimensions of A4 portrait paper and is set to show
background graphics.
This functionality is dependent on slimming paint v2, which is
automatically enabled if needed.

This can be invoked from the command line with:
content_shell --enable-print-browser "http://example.com"

The virtual test environment can be run using:
run-webkit-tests virtual/print_browser

Design doc:
https://docs.google.com/document/d/1G2RoH7yiwh_vosEHsHTwqETBvt2ij8p9ov0D3kIz4...
BUG=667547
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[gozzard, 2017-02-10 01:26:49]

PTAL nainar

[nainar, 2017-02-10 01:51:19]

On 2017/02/10 at 01:26:49, gozzard wrote:
> PTAL nainar

Yup, this lgtm. Happy to maintain this and carry on with exploring how to hook
up printing to test harness in greater detail. 

Thank you so much nasko@ and pdr@ for the reviews!

[gozzard, 2017-02-10 02:52:42]

The CQ bit was checked by gozzard@google.com

[gozzard, 2017-02-10 02:52:42]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org,
pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2672983003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-10 02:53:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 08:53:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 08:53:52]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[nainar, 2017-02-10 09:30:13]

The CQ bit was checked by nainar@chromium.org

[commit-bot: I haz the power, 2017-02-10 09:30:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 10:59:10]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486719013208540,
"parent_rev": "a9cae0d0eb1e430848ca10bdbfd22cc1f373610e", "commit_rev":
"080936f5193590e65409c60127a510f71e910d73"}

[commit-bot: I haz the power, 2017-02-10 10:59:46]

Description was changed from

==========
Implements PrintBrowser mode.

Added --enable-print-browser runtime flag.

Renders the frame in print mode in response to the enable-print-browser
runtime flag.
Currently defaults to dimensions of A4 portrait paper and is set to show
background graphics.
This functionality is dependent on slimming paint v2, which is
automatically enabled if needed.

This can be invoked from the command line with:
content_shell --enable-print-browser "http://example.com"

The virtual test environment can be run using:
run-webkit-tests virtual/print_browser

Design doc:
https://docs.google.com/document/d/1G2RoH7yiwh_vosEHsHTwqETBvt2ij8p9ov0D3kIz4...
BUG=667547
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Implements PrintBrowser mode.

Added --enable-print-browser runtime flag.

Renders the frame in print mode in response to the enable-print-browser
runtime flag.
Currently defaults to dimensions of A4 portrait paper and is set to show
background graphics.
This functionality is dependent on slimming paint v2, which is
automatically enabled if needed.

This can be invoked from the command line with:
content_shell --enable-print-browser "http://example.com"

The virtual test environment can be run using:
run-webkit-tests virtual/print_browser

Design doc:
https://docs.google.com/document/d/1G2RoH7yiwh_vosEHsHTwqETBvt2ij8p9ov0D3kIz4...
BUG=667547
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2672983003
Cr-Commit-Position: refs/heads/master@{#449585}
Committed:
https://chromium.googlesource.com/chromium/src/+/080936f5193590e65409c60127a5...
==========

[commit-bot: I haz the power, 2017-02-10 10:59:48]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/080936f5193590e65409c60127a5...