Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2672893003: EG test for sessionStorage sharing. (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 10 months ago
Reviewers:
baxley
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

EG test for sessionStorage sharing. Newly written test reproduces crbug.com/681434 and currently disabled because of this bug. BUG=681434 Review-Url: https://codereview.chromium.org/2672893003 Cr-Commit-Position: refs/heads/master@{#448042} Committed: https://chromium.googlesource.com/chromium/src/+/31501962d5fe6c4e6729a6f6aa14c96170bdb6ce

Patch Set 1 #

Patch Set 2 : Self review #

Total comments: 2

Patch Set 3 : Addressed review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M ios/chrome/browser/web/window_open_by_dom_egtest.mm View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M ios/testing/data/http_server_files/window_open.html View 1 1 chunk +12 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
Eugene But (OOO till 7-30)
3 years, 10 months ago (2017-02-02 22:27:02 UTC) #3
baxley
LGTM Thank you for writing an automated test case for a bug! https://codereview.chromium.org/2672893003/diff/20001/ios/chrome/browser/web/window_open_by_dom_egtest.mm File ios/chrome/browser/web/window_open_by_dom_egtest.mm ...
3 years, 10 months ago (2017-02-03 15:23:38 UTC) #7
Eugene But (OOO till 7-30)
Thanks! https://codereview.chromium.org/2672893003/diff/20001/ios/chrome/browser/web/window_open_by_dom_egtest.mm File ios/chrome/browser/web/window_open_by_dom_egtest.mm (right): https://codereview.chromium.org/2672893003/diff/20001/ios/chrome/browser/web/window_open_by_dom_egtest.mm#newcode63 ios/chrome/browser/web/window_open_by_dom_egtest.mm:63: // Tests that |sessionStorage| content is available for ...
3 years, 10 months ago (2017-02-03 19:04:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672893003/40001
3 years, 10 months ago (2017-02-03 19:05:25 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 19:26:10 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/31501962d5fe6c4e6729a6f6aa14...

Powered by Google App Engine
This is Rietveld 408576698