Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2672853002: Reland of Use trace-pc-guard for libFuzzer. (Closed)

Created:
3 years, 10 months ago by Oliver Chang
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Use trace-pc-guard for libFuzzer. (patchset #1 id:1 of https://codereview.chromium.org/2668093004/ ) Reason for revert: Got upgraded builders. Original issue's description: > Revert of Use trace-pc-guard for libFuzzer. (patchset #1 id:1 of https://codereview.chromium.org/2665243002/ ) > > Reason for revert: > causing build failures: https://crbug.com/687570 > > Original issue's description: > > Use trace-pc-guard for libFuzzer. > > > > BUG=651540 > > > > Review-Url: https://codereview.chromium.org/2665243002 > > Cr-Commit-Position: refs/heads/master@{#447392} > > Committed: https://chromium.googlesource.com/chromium/src/+/002dca9ca557b96939ed99ae9450dcb42f5d1620 > > TBR=inferno@chromium.org,kcc@chromium.org,aizatsky@chromium.org,mmoroz@chromium.org,dpranke@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=651540 > > Review-Url: https://codereview.chromium.org/2668093004 > Cr-Commit-Position: refs/heads/master@{#447552} > Committed: https://chromium.googlesource.com/chromium/src/+/23d6de2177b812285946bce6f459815799d825c5 TBR=inferno@chromium.org,kcc@chromium.org,aizatsky@chromium.org,mmoroz@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=651540 Review-Url: https://codereview.chromium.org/2672853002 Cr-Commit-Position: refs/heads/master@{#447825} Committed: https://chromium.googlesource.com/chromium/src/+/28fbc2f08338a66ed15e96fd2841c66cbbda212f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/sanitizers/sanitizers.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Oliver Chang
Created Reland of Use trace-pc-guard for libFuzzer.
3 years, 10 months ago (2017-02-02 18:39:15 UTC) #1
inferno
lgtm
3 years, 10 months ago (2017-02-02 18:51:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672853002/1
3 years, 10 months ago (2017-02-02 18:51:53 UTC) #4
Dirk Pranke
lgtm
3 years, 10 months ago (2017-02-02 19:05:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/28fbc2f08338a66ed15e96fd2841c66cbbda212f
3 years, 10 months ago (2017-02-02 20:03:55 UTC) #8
Oliver Chang
3 years, 10 months ago (2017-02-03 16:59:58 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2675983002/ by ochang@chromium.org.

The reason for reverting is: Still borked on bots..

Powered by Google App Engine
This is Rietveld 408576698