Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2665243002: Use trace-pc-guard for libFuzzer. (Closed)

Created:
3 years, 10 months ago by Oliver Chang
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use trace-pc-guard for libFuzzer. BUG=651540 Review-Url: https://codereview.chromium.org/2665243002 Cr-Commit-Position: refs/heads/master@{#447392} Committed: https://chromium.googlesource.com/chromium/src/+/002dca9ca557b96939ed99ae9450dcb42f5d1620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/sanitizers/sanitizers.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
Oliver Chang
PTAL. Dirk: ptal as an OWNER of build/config. Others: I'll need to make some changes ...
3 years, 10 months ago (2017-01-31 20:55:02 UTC) #4
Dirk Pranke
lgtm assuming approval from one of the other reviewers. We should add OWNERS to this ...
3 years, 10 months ago (2017-01-31 22:40:30 UTC) #5
kcc2
lgtm
3 years, 10 months ago (2017-01-31 22:41:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665243002/1
3 years, 10 months ago (2017-02-01 00:52:40 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/002dca9ca557b96939ed99ae9450dcb42f5d1620
3 years, 10 months ago (2017-02-01 00:59:57 UTC) #15
Oliver Chang
3 years, 10 months ago (2017-02-01 17:45:12 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2668093004/ by ochang@chromium.org.

The reason for reverting is: causing build failures: https://crbug.com/687570.

Powered by Google App Engine
This is Rietveld 408576698