Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2650193002: [debugger] remove debugger statement support from FCG/CS. (Closed)

Created:
3 years, 11 months ago by Yang
Modified:
3 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, Yang, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] remove debugger statement support from FCG/CS. R=mstarzinger@chromium.org Review-Url: https://codereview.chromium.org/2650193002 Cr-Original-Commit-Position: refs/heads/master@{#42892} Committed: https://chromium.googlesource.com/v8/v8/+/eef855a1dc956e9db03ec09abca1d732d379861b Review-Url: https://codereview.chromium.org/2650193002 Cr-Commit-Position: refs/heads/master@{#43360} Committed: https://chromium.googlesource.com/v8/v8/+/3f303da2920e21f631325e54904290ba20b86827

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comment #

Patch Set 3 : remove unnecessary include #

Patch Set 4 : rebase #

Patch Set 5 : Disable always-opt #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -139 lines) Patch
M src/arm/macro-assembler-arm.h View 1 2 3 4 5 1 chunk +1 line, -5 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 3 4 5 1 chunk +0 lines, -10 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 2 3 4 5 1 chunk +1 line, -5 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 3 4 5 1 chunk +0 lines, -9 lines 0 comments Download
M src/assembler.h View 1 2 3 3 chunks +1 line, -5 lines 0 comments Download
M src/assembler.cc View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M src/ast/ast.h View 1 2 3 4 5 1 chunk +1 line, -17 lines 0 comments Download
M src/ast/ast-numbering.cc View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 4 5 1 chunk +2 lines, -3 lines 0 comments Download
M src/debug/debug.cc View 1 2 3 4 5 5 chunks +3 lines, -12 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 2 3 4 5 1 chunk +2 lines, -7 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 2 3 4 5 1 chunk +1 line, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 2 3 4 5 1 chunk +1 line, -5 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 3 4 5 1 chunk +0 lines, -10 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 2 3 4 5 1 chunk +1 line, -5 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 2 3 4 5 1 chunk +0 lines, -10 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 2 3 4 5 1 chunk +1 line, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 1 2 3 4 3 chunks +19 lines, -10 lines 0 comments Download
M test/debugger/debug/debug-evaluate-closure.js View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M test/debugger/debug/debug-set-variable-value.js View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M test/debugger/debug/es6/debug-evaluate-blockscopes.js View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M test/debugger/debug/regress/regress-crbug-323936.js View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 29 (18 generated)
Yang
3 years, 11 months ago (2017-01-24 13:01:32 UTC) #1
Michael Starzinger
LGTM. I love it! https://codereview.chromium.org/2650193002/diff/1/src/full-codegen/full-codegen.cc File src/full-codegen/full-codegen.cc (left): https://codereview.chromium.org/2650193002/diff/1/src/full-codegen/full-codegen.cc#oldcode1237 src/full-codegen/full-codegen.cc:1237: PrepareForBailoutForId(stmt->DebugBreakId(), BailoutState::NO_REGISTERS); suggestion: We can ...
3 years, 11 months ago (2017-01-24 13:10:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650193002/40001
3 years, 11 months ago (2017-01-24 13:20:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/11811)
3 years, 11 months ago (2017-01-24 13:27:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650193002/80001
3 years, 10 months ago (2017-02-02 13:39:29 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/v8/v8/+/eef855a1dc956e9db03ec09abca1d732d379861b
3 years, 10 months ago (2017-02-02 14:21:10 UTC) #17
kozy
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2672823007/ by kozyatinskiy@chromium.org. ...
3 years, 10 months ago (2017-02-04 17:34:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650193002/80001
3 years, 10 months ago (2017-02-21 13:48:19 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/17696) v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 10 months ago (2017-02-21 13:49:50 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650193002/100001
3 years, 10 months ago (2017-02-22 08:19:16 UTC) #26
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 08:45:17 UTC) #29
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/3f303da2920e21f631325e54904290ba20b...

Powered by Google App Engine
This is Rietveld 408576698