|
|
DescriptionGenerate nonproperty 'explicitInheritance' in ComputedStyleBase.
Move the nonproperty field 'explicitInheritance' to be generated in
ComputedStyleBase. Also moved getter / setter methods to be generated in
ComputedStyleBase.
Note that this renames m_explicitInheritance to something much longer.
This shouldn't affect anything since the member is private and only used
within the generated class.
Also, after this patch, ComputedStyle returns to its original size.
BUG=628043
Review-Url: https://codereview.chromium.org/2672703002
Cr-Commit-Position: refs/heads/master@{#454520}
Committed: https://chromium.googlesource.com/chromium/src/+/c26572689b73d3ecee94cd96257f4822d6e21950
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Size check #Patch Set 4 : Size check #
Messages
Total messages: 36 (24 generated)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
shend@chromium.org changed reviewers: + nainar@chromium.org
Hi Naina, PTAL
lgtm
shend@chromium.org changed reviewers: + sashab@chromium.org
Hi Sasha, PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Need to update StyleBuilder call to setHasExplicitlyInheritedProperties
Also in CL desc: 'something much longer' -> 'm_fejfesfjsefljef, which is much longer'
On 2017/02/03 at 05:08:34, sashab wrote: > Also in CL desc: 'something much longer' -> 'm_fejfesfjsefljef, which is much longer' Yep; I omitted it because it was so long :P
On 2017/02/03 at 05:08:15, sashab wrote: > Need to update StyleBuilder call to setHasExplicitlyInheritedProperties Hmm, did you mean StyleBuilderCustom? In which case, it already calls setHasExplicitlyInheritedProperties. It's probably not clear in the CL desc, but I did not change the name of the setters/getters, only the member variable name, which should not affect any external class.
Ohh sorry sorry. I may have done these reviews while half-asleep... Gonna pause reviewing these until you do that rename, then ping me again and I'll TAL. S
Hi Sasha, since we're not doing the rename anymore, PTAL again?
LGTM, this will conflict with your variable reference one in the py file I'd make one a tracking branch of the other, in git: # checkout the patch to land 2nd git checkout explicit_inheritance # set it to track the patch to land 1st git branch --set-upstream-to=variable_reference # rebase & resolve the conflict(s) git rebase # now upload the new diff (diff will be off the other patch now) and it will land git cl upload
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
Description was changed from ========== Generate nonproperty 'explicitInheritance' in ComputedStyleBase. Move the nonproperty field 'explicitInheritance' to be generated in ComputedStyleBase. Also moved getter / setter methods to be generated in ComputedStyleBase. Note that this renames m_explicitInheritance to something much longer. This shouldn't affect anything since the member is private and only used within the generated class. BUG=628043 ========== to ========== Generate nonproperty 'explicitInheritance' in ComputedStyleBase. Move the nonproperty field 'explicitInheritance' to be generated in ComputedStyleBase. Also moved getter / setter methods to be generated in ComputedStyleBase. Note that this renames m_explicitInheritance to something much longer. This shouldn't affect anything since the member is private and only used within the generated class. Also, after this patch, ComputedStyleBase uses exactly 80 bits, so there is no more padding from inheritance. Hence, this patch returns ComputedStyle to its original size. BUG=628043 ==========
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Generate nonproperty 'explicitInheritance' in ComputedStyleBase. Move the nonproperty field 'explicitInheritance' to be generated in ComputedStyleBase. Also moved getter / setter methods to be generated in ComputedStyleBase. Note that this renames m_explicitInheritance to something much longer. This shouldn't affect anything since the member is private and only used within the generated class. Also, after this patch, ComputedStyleBase uses exactly 80 bits, so there is no more padding from inheritance. Hence, this patch returns ComputedStyle to its original size. BUG=628043 ========== to ========== Generate nonproperty 'explicitInheritance' in ComputedStyleBase. Move the nonproperty field 'explicitInheritance' to be generated in ComputedStyleBase. Also moved getter / setter methods to be generated in ComputedStyleBase. Note that this renames m_explicitInheritance to something much longer. This shouldn't affect anything since the member is private and only used within the generated class. Also, after this patch, ComputedStyle returns to its original size. BUG=628043 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org, sashab@chromium.org Link to the patchset: https://codereview.chromium.org/2672703002/#ps60001 (title: "Size check")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488519223996580, "parent_rev": "3d48625f7b09df0495e40c7c1ff1cafe00e5693b", "commit_rev": "c26572689b73d3ecee94cd96257f4822d6e21950"}
Message was sent while issue was closed.
Description was changed from ========== Generate nonproperty 'explicitInheritance' in ComputedStyleBase. Move the nonproperty field 'explicitInheritance' to be generated in ComputedStyleBase. Also moved getter / setter methods to be generated in ComputedStyleBase. Note that this renames m_explicitInheritance to something much longer. This shouldn't affect anything since the member is private and only used within the generated class. Also, after this patch, ComputedStyle returns to its original size. BUG=628043 ========== to ========== Generate nonproperty 'explicitInheritance' in ComputedStyleBase. Move the nonproperty field 'explicitInheritance' to be generated in ComputedStyleBase. Also moved getter / setter methods to be generated in ComputedStyleBase. Note that this renames m_explicitInheritance to something much longer. This shouldn't affect anything since the member is private and only used within the generated class. Also, after this patch, ComputedStyle returns to its original size. BUG=628043 Review-Url: https://codereview.chromium.org/2672703002 Cr-Commit-Position: refs/heads/master@{#454520} Committed: https://chromium.googlesource.com/chromium/src/+/c26572689b73d3ecee94cd96257f... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/c26572689b73d3ecee94cd96257f... |