Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm

Issue 2672673002: Removed investigation CHECK from didCommitNavigation. (Closed)
Patch Set: Removed unused method Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/web/web_state/ui/crw_wk_navigation_states.mm ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/web/web_state/ui/crw_wk_navigation_states.h" 5 #import "ios/web/web_state/ui/crw_wk_navigation_states.h"
6 6
7 #import <WebKit/WebKit.h> 7 #import <WebKit/WebKit.h>
8 8
9 #import "base/mac/scoped_nsobject.h" 9 #import "base/mac/scoped_nsobject.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 23 matching lines...) Expand all
34 34
35 // navigation_2 is added later and hence the latest. 35 // navigation_2 is added later and hence the latest.
36 [states_ setState:WKNavigationState::REQUESTED forNavigation:navigation2_]; 36 [states_ setState:WKNavigationState::REQUESTED forNavigation:navigation2_];
37 EXPECT_EQ(navigation2_, [states_ lastAddedNavigation]); 37 EXPECT_EQ(navigation2_, [states_ lastAddedNavigation]);
38 38
39 // Updating state for existing navigation does not make it the latest. 39 // Updating state for existing navigation does not make it the latest.
40 [states_ setState:WKNavigationState::STARTED forNavigation:navigation1_]; 40 [states_ setState:WKNavigationState::STARTED forNavigation:navigation1_];
41 EXPECT_EQ(navigation2_, [states_ lastAddedNavigation]); 41 EXPECT_EQ(navigation2_, [states_ lastAddedNavigation]);
42 } 42 }
43 43
44 // Tests |stateForNavigation:| method.
45 TEST_F(CRWWKNavigationStatesTest, StateForNavigation) {
46 [states_ setState:WKNavigationState::REQUESTED forNavigation:navigation1_];
47 EXPECT_EQ(WKNavigationState::REQUESTED,
48 [states_ stateForNavigation:navigation1_]);
49
50 [states_ setState:WKNavigationState::REQUESTED forNavigation:navigation2_];
51 EXPECT_EQ(WKNavigationState::REQUESTED,
52 [states_ stateForNavigation:navigation2_]);
53
54 [states_ setState:WKNavigationState::STARTED forNavigation:navigation1_];
55 EXPECT_EQ(WKNavigationState::STARTED,
56 [states_ stateForNavigation:navigation1_]);
57 }
58
59 } // namespace web 44 } // namespace web
OLDNEW
« no previous file with comments | « ios/web/web_state/ui/crw_wk_navigation_states.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698