Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2672633004: [Reading List] Accept all favicon in Reading List view. (Closed)

Created:
3 years, 10 months ago by Olivier
Modified:
3 years, 10 months ago
Reviewers:
gambard
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reading List] Accept all favicon in Reading List view. Current behavior is to accept favicons of size 16x16 * device scale factor. Plenty of mobile sites have only 16x16 icons, and this means we have mostly fallback icons. Set the minimum size to 1 to accept any favicons. BUG=688374 Review-Url: https://codereview.chromium.org/2672633004 Cr-Commit-Position: refs/heads/master@{#450301} Committed: https://chromium.googlesource.com/chromium/src/+/d4541ca729baa0628bef1304616e3a3721f614bb

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
Olivier
3 years, 10 months ago (2017-02-03 13:55:38 UTC) #2
gambard
https://codereview.chromium.org/2672633004/diff/1/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm File ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm (left): https://codereview.chromium.org/2672633004/diff/1/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm#oldcode231 ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm:231: minFaviconSize:kFaviconMinSize This is 16. From the method comment it ...
3 years, 10 months ago (2017-02-03 14:20:29 UTC) #3
Olivier
https://codereview.chromium.org/2672633004/diff/1/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm File ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm (left): https://codereview.chromium.org/2672633004/diff/1/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm#oldcode231 ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm:231: minFaviconSize:kFaviconMinSize On 2017/02/03 14:20:29, gambard wrote: > This is ...
3 years, 10 months ago (2017-02-03 14:25:31 UTC) #4
gambard
lgtm but maybe ask mardini/amy?
3 years, 10 months ago (2017-02-03 14:34:00 UTC) #5
Olivier
mardini asked me to do that. I will add amy to the bug.
3 years, 10 months ago (2017-02-03 14:34:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672633004/1
3 years, 10 months ago (2017-02-14 08:00:58 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/239170) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-02-14 08:03:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672633004/20001
3 years, 10 months ago (2017-02-14 08:56:19 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 09:22:14 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d4541ca729baa0628bef1304616e...

Powered by Google App Engine
This is Rietveld 408576698