[Reading List] Accept all favicon in Reading List view.

[Reading List] Accept all favicon in Reading List view.

Current behavior is to accept favicons of size 16x16 * device scale factor.
Plenty of mobile sites have only 16x16 icons, and this means we have mostly
fallback icons.
Set the minimum size to 1 to accept any favicons.

BUG=688374
Review-Url: https://codereview.chromium.org/2672633004
Cr-Commit-Position: refs/heads/master@{#450301}
Committed: https://chromium.googlesource.com/chromium/src/+/d4541ca729baa0628bef1304616e3a3721f614bb

[Olivier, 2017-02-03 13:55:37]

olivierrobin@chromium.org changed reviewers:
+ gambard@chromium.org

[gambard, 2017-02-03 14:20:29]

https://codereview.chromium.org/2672633004/diff/1/ios/chrome/browser/ui/readi...
File ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm (left):

https://codereview.chromium.org/2672633004/diff/1/ios/chrome/browser/ui/readi...
ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm:231:
minFaviconSize:kFaviconMinSize
This is 16. From the method comment it should render the 16x16 favicon.
Do we want 1x1 favicon?

[Olivier, 2017-02-03 14:25:31]

https://codereview.chromium.org/2672633004/diff/1/ios/chrome/browser/ui/readi...
File ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm (left):

https://codereview.chromium.org/2672633004/diff/1/ios/chrome/browser/ui/readi...
ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm:231:
minFaviconSize:kFaviconMinSize
On 2017/02/03 14:20:29, gambard wrote:
> This is 16. From the method comment it should render the 16x16 favicon.
> Do we want 1x1 favicon?

This is 16x16 * scalefactor.
I think we want 16x16 even on 2x devices.

[gambard, 2017-02-03 14:34:00]

lgtm but maybe ask mardini/amy?

[Olivier, 2017-02-03 14:34:52]

mardini asked me to do that.
I will add amy to the bug.

[Olivier, 2017-02-14 08:00:34]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2017-02-14 08:00:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 08:03:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 08:03:42]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Olivier, 2017-02-14 08:55:55]

The CQ bit was checked by olivierrobin@chromium.org

[Olivier, 2017-02-14 08:55:56]

The patchset sent to the CQ was uploaded after l-g-t-m from gambard@chromium.org
Link to the patchset: https://codereview.chromium.org/2672633004/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-14 08:56:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 09:21:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487062555998780,
"parent_rev": "7a3481c035a42c8fef365f2f9d94c78305cee048", "commit_rev":
"d4541ca729baa0628bef1304616e3a3721f614bb"}

[commit-bot: I haz the power, 2017-02-14 09:22:13]

Description was changed from

==========
[Reading List] Accept all favicon in Reading List view.

Current behavior is to accept favicons of size 16x16 * device scale factor.
Plenty of mobile sites have only 16x16 icons, and this means we have mostly
fallback icons.
Set the minimum size to 1 to accept any favicons.

BUG=688374
==========

to

==========
[Reading List] Accept all favicon in Reading List view.

Current behavior is to accept favicons of size 16x16 * device scale factor.
Plenty of mobile sites have only 16x16 icons, and this means we have mostly
fallback icons.
Set the minimum size to 1 to accept any favicons.

BUG=688374

Review-Url: https://codereview.chromium.org/2672633004
Cr-Commit-Position: refs/heads/master@{#450301}
Committed:
https://chromium.googlesource.com/chromium/src/+/d4541ca729baa0628bef1304616e...
==========

[commit-bot: I haz the power, 2017-02-14 09:22:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d4541ca729baa0628bef1304616e...