Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm

Issue 2672633004: [Reading List] Accept all favicon in Reading List view. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
diff --git a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
index c29af39efe29996cf98a3ef58aa1dbbf80122e4c..fcc33180c0d03635795e3969544d8d1626d5178e 100644
--- a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
+++ b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
@@ -214,9 +214,12 @@ using ItemsMapByDate = std::multimap<int64_t, ReadingListCollectionViewItem*>;
return _attributesProvider;
}
+ // Accept any favicon even the smallest ones (16x16) as it is better than the
+ // fallback icon.
+ // Pass 1 as minimum size to avoid empty favicons.
_attributesProvider = [[FaviconAttributesProvider alloc]
initWithFaviconSize:kFaviconPreferredSize
- minFaviconSize:kFaviconMinSize
+ minFaviconSize:1
largeIconService:self.largeIconService];
return _attributesProvider;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698