Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2672473002: Revert of [RootLayerScrolls] Fix ScrollingCoordinatorTest (Closed)

Created:
3 years, 10 months ago by johnme
Modified:
3 years, 10 months ago
Reviewers:
skobes, szager1
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [RootLayerScrolls] Fix ScrollingCoordinatorTest (patchset #2 id:20001 of https://codereview.chromium.org/2658253003/ ) Reason for revert: Broke https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/60268 All/ScrollingCoordinatorTest.iframeScrolling/1 fails consistently with: ../../third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp:687: Failure Value of: innerCompositor->layerForHorizontalScrollbar() Actual: false Expected: true Original issue's description: > [RootLayerScrolls] Fix ScrollingCoordinatorTest > > BUG=490942 > R=skobes@chromium.org > > Review-Url: https://codereview.chromium.org/2658253003 > Cr-Commit-Position: refs/heads/master@{#447376} > Committed: https://chromium.googlesource.com/chromium/src/+/f32ea8e81f35c9313818e3f57d960516df478670 TBR=skobes@chromium.org,szager@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=490942 Review-Url: https://codereview.chromium.org/2672473002 Cr-Commit-Position: refs/heads/master@{#447496} Committed: https://chromium.googlesource.com/chromium/src/+/08662506ee77385204da644804c26dc8701e796d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -150 lines) Patch
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 41 chunks +127 lines, -132 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 2 chunks +2 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/web/tests/data/has-non-layer-viewport-constrained-objects.html View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/data/iframe-background-attachment-fixed-inner.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
johnme
Created Revert of [RootLayerScrolls] Fix ScrollingCoordinatorTest
3 years, 10 months ago (2017-02-01 13:08:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672473002/1
3 years, 10 months ago (2017-02-01 13:08:21 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 13:11:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/08662506ee77385204da644804c2...

Powered by Google App Engine
This is Rietveld 408576698