Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2672453002: [promises] Fix .arguments on builtin function. (Closed)

Created:
3 years, 10 months ago by neis
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] Fix .arguments on builtin function. Using .caller, one can get access to the internal function that invokes the handler passed to Promise.prototype.then. This internal function is a TF builtin that was set up as non-native and without an argument adaptor. As a consequence of this, when accessing .arguments on it, the frame-walking logic in the .arguments accessor thinks the number of arguments is -1 and we try to allocate an array of size -1. This CL marks the builtin function as native (making its .arguments be null), along with a few others that may have been incorrect in the same way. BUG=chromium:682349 Review-Url: https://codereview.chromium.org/2672453002 Cr-Commit-Position: refs/heads/master@{#42855} Committed: https://chromium.googlesource.com/v8/v8/+/5020db7f9c83bfbc47d2e5563c2a8b9889cd1bf4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M src/bootstrapper.cc View 8 chunks +0 lines, -8 lines 0 comments Download
A test/mjsunit/regress/regress-682349.js View 1 chunk +13 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (13 generated)
neis
ptal, depends on the previously sent CL
3 years, 10 months ago (2017-02-01 13:47:34 UTC) #10
Benedikt Meurer
lgtm
3 years, 10 months ago (2017-02-01 13:55:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672453002/1
3 years, 10 months ago (2017-02-01 14:04:23 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 14:06:44 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5020db7f9c83bfbc47d2e5563c2a8b9889c...

Powered by Google App Engine
This is Rietveld 408576698