Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2667993005: [bootstrapper] Refactor CreateFunction and InstallFunction. (Closed)

Created:
3 years, 10 months ago by neis
Modified:
3 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, gsathya
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[bootstrapper] Refactor CreateFunction and InstallFunction. Move set_native(true) from InstallFunction into CreateFunction in order to emphasize the places where we create non-native functions. No change in semantics overall. BUG= Review-Url: https://codereview.chromium.org/2667993005 Cr-Commit-Position: refs/heads/master@{#42854} Committed: https://chromium.googlesource.com/v8/v8/+/f555b07354fd163988c73153d63b054441a0856c

Patch Set 1 #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M src/bootstrapper.cc View 1 21 chunks +25 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
neis
ptal
3 years, 10 months ago (2017-02-01 13:46:55 UTC) #10
Benedikt Meurer
lgtm LGTM, but can you fix the nativeness of the various builtins that are not ...
3 years, 10 months ago (2017-02-01 13:58:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667993005/20001
3 years, 10 months ago (2017-02-01 14:01:25 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 14:03:05 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/f555b07354fd163988c73153d63b054441a...

Powered by Google App Engine
This is Rietveld 408576698