Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 10 months ago by neis Modified:
3 years, 10 months ago Reviewers:
Benedikt Meurer CC:
v8-reviews_googlegroups.com, gsathya Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[bootstrapper] Refactor CreateFunction and InstallFunction.
Move set_native(true) from InstallFunction into CreateFunction in order to
emphasize the places where we create non-native functions.
No change in semantics overall.
BUG=
Review-Url: https://codereview.chromium.org/2667993005
Cr-Commit-Position: refs/heads/master@{#42854}
Committed: https://chromium.googlesource.com/v8/v8/+/f555b07354fd163988c73153d63b054441a0856c
Patch Set 1 #Patch Set 2 : Fix. #
Created: 3 years, 10 months ago
Dependent Patchsets: Messages
Total messages: 16 (12 generated)
The CQ bit was checked by neis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/16730) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
The CQ bit was checked by neis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
neis@chromium.org changed reviewers: + bmeurer@chromium.org
ptal
lgtm LGTM, but can you fix the nativeness of the various builtins that are not marked native in a follow up CL?
The CQ bit was checked by neis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485957674413100,
"parent_rev": "87d309dadd062c1c4d279505aa5e36df12026016", "commit_rev":
"f555b07354fd163988c73153d63b054441a0856c"}
Message was sent while issue was closed.
Description was changed from ========== [bootstrapper] Refactor CreateFunction and InstallFunction. Move set_native(true) from InstallFunction into CreateFunction in order to emphasize the places where we create non-native functions. No change in semantics overall. BUG= ========== to ========== [bootstrapper] Refactor CreateFunction and InstallFunction. Move set_native(true) from InstallFunction into CreateFunction in order to emphasize the places where we create non-native functions. No change in semantics overall. BUG= Review-Url: https://codereview.chromium.org/2667993005 Cr-Commit-Position: refs/heads/master@{#42854} Committed: https://chromium.googlesource.com/v8/v8/+/f555b07354fd163988c73153d63b054441a... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/f555b07354fd163988c73153d63b054441a... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
