Don't create MostVisitedSites in incognito

Don't create MostVisitedSites in incognito

With NTPTilesInInstantService enabled, InstantService attempts to create
a MostVisitedSites instance even in incognito profiles, which caused a
crash.
This CL changes ChromeMostVisitedSitesFactory to return nullptr for
incognito profiles, and also updates InstantService to properly handle
the returned nullptr.

BUG=687507
Review-Url: https://codereview.chromium.org/2672443002
Cr-Commit-Position: refs/heads/master@{#447495}
Committed: https://chromium.googlesource.com/chromium/src/+/837e405817fcb63cd3652381d3fb8aae3c28e16d

[Marc Treib, 2017-02-01 11:08:24]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 11:08:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-02-01 11:09:48]

treib@chromium.org changed reviewers:
+ sfiera@chromium.org

[Marc Treib, 2017-02-01 11:09:49]

PTAL!

[sfiera, 2017-02-01 11:24:57]

LGTM

https://codereview.chromium.org/2672443002/diff/1/chrome/browser/search/insta...
File chrome/browser/search/instant_service.cc (right):

https://codereview.chromium.org/2672443002/diff/1/chrome/browser/search/insta...
chrome/browser/search/instant_service.cc:107:
most_visited_sites_->SetMostVisitedURLsObserver(this, 8);
FYI, merge conflict with https://crrev.com/2619993002

[commit-bot: I haz the power, 2017-02-01 12:27:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 12:27:15]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-02-01 12:42:45]

treib@chromium.org changed reviewers:
+ mastiz@chromium.org

[Marc Treib, 2017-02-01 12:42:46]

+mastiz explicitly: FYI merge conflict. Scream if you want to land your CL first
;)

https://codereview.chromium.org/2672443002/diff/1/chrome/browser/search/insta...
File chrome/browser/search/instant_service.cc (right):

https://codereview.chromium.org/2672443002/diff/1/chrome/browser/search/insta...
chrome/browser/search/instant_service.cc:107:
most_visited_sites_->SetMostVisitedURLsObserver(this, 8);
On 2017/02/01 11:24:57, sfiera wrote:
> FYI, merge conflict with https://crrev.com/2619993002

Thanks for the heads-up!
Since that one doesn't look like it'll land immediately, I guess I'll just go
ahead and land this. Should be trivial to resolve either way.

[mastiz, 2017-02-01 13:03:39]

https://codereview.chromium.org/2672443002/diff/1/chrome/browser/search/insta...
File chrome/browser/search/instant_service.cc (right):

https://codereview.chromium.org/2672443002/diff/1/chrome/browser/search/insta...
chrome/browser/search/instant_service.cc:107:
most_visited_sites_->SetMostVisitedURLsObserver(this, 8);
On 2017/02/01 12:42:46, Marc Treib wrote:
> On 2017/02/01 11:24:57, sfiera wrote:
> > FYI, merge conflict with https://crrev.com/2619993002
> 
> Thanks for the heads-up!
> Since that one doesn't look like it'll land immediately, I guess I'll just go
> ahead and land this. Should be trivial to resolve either way.

Don't worry about conflicts, I can resolve those if needed. In fact, I'm not
even sure I'll go ahead with the CL above, thanks for bringing it up anyway.

[Marc Treib, 2017-02-01 13:04:46]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2017-02-01 13:05:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 13:08:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485954286455510, "parent_rev":
"ab97ff6908a975ddf24b72fef99d2539d8d43aa0", "commit_rev":
"837e405817fcb63cd3652381d3fb8aae3c28e16d"}

[commit-bot: I haz the power, 2017-02-01 13:09:33]

Description was changed from

==========
Don't create MostVisitedSites in incognito

With NTPTilesInInstantService enabled, InstantService attempts to create
a MostVisitedSites instance even in incognito profiles, which caused a
crash.
This CL changes ChromeMostVisitedSitesFactory to return nullptr for
incognito profiles, and also updates InstantService to properly handle
the returned nullptr.

BUG=687507
==========

to

==========
Don't create MostVisitedSites in incognito

With NTPTilesInInstantService enabled, InstantService attempts to create
a MostVisitedSites instance even in incognito profiles, which caused a
crash.
This CL changes ChromeMostVisitedSitesFactory to return nullptr for
incognito profiles, and also updates InstantService to properly handle
the returned nullptr.

BUG=687507

Review-Url: https://codereview.chromium.org/2672443002
Cr-Commit-Position: refs/heads/master@{#447495}
Committed:
https://chromium.googlesource.com/chromium/src/+/837e405817fcb63cd3652381d3fb...
==========

[commit-bot: I haz the power, 2017-02-01 13:09:35]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/837e405817fcb63cd3652381d3fb...