Don't create MostVisitedSites in incognito

chrome/browser/search/instant_service.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/search/instant_service.h"
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/feature_list.h"
@@ skipping 85 matching lines @@
   registrar_.Add(this,
                  content::NOTIFICATION_RENDERER_PROCESS_CREATED,
                  content::NotificationService::AllSources());
   registrar_.Add(this,
                  content::NOTIFICATION_RENDERER_PROCESS_TERMINATED,
                  content::NotificationService::AllSources());
 
   if (base::FeatureList::IsEnabled(kNtpTilesFeature)) {
     most_visited_sites_ =
         ChromeMostVisitedSitesFactory::NewForProfile(profile_);
-    most_visited_sites_->SetMostVisitedURLsObserver(this, 8);
+    if (most_visited_sites_)
+      most_visited_sites_->SetMostVisitedURLsObserver(this, 8);

[sfiera, 2017/02/01 11:24:57]

FYI, merge conflict with https://crrev.com/2619993002

[Marc Treib, 2017/02/01 12:42:46]

Thanks for the heads-up!
Since that one doesn't look like it'll land immediately, I guess I'll just go
ahead and land this. Should be trivial to resolve either way.

[mastiz, 2017/02/01 13:03:39]

Don't worry about conflicts, I can resolve those if needed. In fact, I'm not
even sure I'll go ahead with the CL above, thanks for bringing it up anyway.

   } else {
     top_sites_ = TopSitesFactory::GetForProfile(profile_);
     if (top_sites_) {
       top_sites_->AddObserver(this);
       // Immediately query the TopSites state.
       TopSitesChanged(top_sites_.get(),
                       history::TopSitesObserver::ChangeReason::MOST_VISITED);
     }
   }
 
@@ skipping 387 matching lines @@
 void InstantService::ResetInstantSearchPrerendererIfNecessary() {
   if (!search::IsInstantExtendedAPIEnabled())
     return;
 
   GURL url(search::GetSearchResultPrefetchBaseURL(profile_));
   if (!instant_prerenderer_ || instant_prerenderer_->prerender_url() != url) {
     instant_prerenderer_.reset(
         url.is_valid() ? new InstantSearchPrerenderer(profile_, url) : nullptr);
   }
 }