Out-of-line trace() methods of editing template types.

Out-of-line trace() methods of editing template types.

With a simpler trace method infrastructure in place, we
can now define trace methods of the editing templates
out-of-line.

R=haraken
BUG=654985
Review-Url: https://codereview.chromium.org/2672413003
Cr-Commit-Position: refs/heads/master@{#448563}
Committed: https://chromium.googlesource.com/chromium/src/+/ff9c66f0c118f2cacfdaeda9e384eb2e47b33cdc

[sof, 2017-02-06 16:24:10]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 16:24:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 17:51:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 17:51:13]

Dry run: This issue passed the CQ dry run.

[sof, 2017-02-06 18:38:28]

Description was changed from

==========
Out-of-line editing/ templated trace() methods.

With a simpler trace method infrastructure in place, we
can now define these templated-methods out-of-line.

R=
BUG=654985
==========

to

==========
Out-of-line trace() methods of editing template types.

With a simpler trace method infrastructure in place, we
can now define trace methods of the editing templates
out-of-line.

R=
BUG=654985
==========

[sof, 2017-02-06 18:38:52]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org, yosin@chromium.org

[sof, 2017-02-06 18:38:53]

please take a look.

[haraken, 2017-02-07 00:32:04]

LGTM

[sof, 2017-02-07 06:25:37]

Description was changed from

==========
Out-of-line trace() methods of editing template types.

With a simpler trace method infrastructure in place, we
can now define trace methods of the editing templates
out-of-line.

R=
BUG=654985
==========

to

==========
Out-of-line trace() methods of editing template types.

With a simpler trace method infrastructure in place, we
can now define trace methods of the editing templates
out-of-line.

R=haraken
BUG=654985
==========

[sof, 2017-02-07 06:25:50]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2017-02-07 06:26:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 06:47:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486448750384740, "parent_rev":
"bdd4517373c99f0af9c16b9f550193cb89735d66", "commit_rev":
"ff9c66f0c118f2cacfdaeda9e384eb2e47b33cdc"}

[commit-bot: I haz the power, 2017-02-07 06:47:55]

Description was changed from

==========
Out-of-line trace() methods of editing template types.

With a simpler trace method infrastructure in place, we
can now define trace methods of the editing templates
out-of-line.

R=haraken
BUG=654985
==========

to

==========
Out-of-line trace() methods of editing template types.

With a simpler trace method infrastructure in place, we
can now define trace methods of the editing templates
out-of-line.

R=haraken
BUG=654985

Review-Url: https://codereview.chromium.org/2672413003
Cr-Commit-Position: refs/heads/master@{#448563}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff9c66f0c118f2cacfdaeda9e384...
==========

[commit-bot: I haz the power, 2017-02-07 06:47:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ff9c66f0c118f2cacfdaeda9e384...

[sof, 2017-02-07 11:05:57]

https://codereview.chromium.org/2672413003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/EphemeralRange.h (left):

https://codereview.chromium.org/2672413003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EphemeralRange.h:118:
DEFINE_INLINE_TRACE() {
This was an unused trace method (the class is STACK_ALLOCATED()), which I notice
the GC plugin doesn't check for. Would it be worth adding a warning for this, or
should we just silently allow it?

[haraken, 2017-02-07 15:14:18]

On 2017/02/07 11:05:57, sof wrote:
>
https://codereview.chromium.org/2672413003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/EphemeralRange.h (left):
> 
>
https://codereview.chromium.org/2672413003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/EphemeralRange.h:118:
> DEFINE_INLINE_TRACE() {
> This was an unused trace method (the class is STACK_ALLOCATED()), which I
notice
> the GC plugin doesn't check for. Would it be worth adding a warning for this,
or
> should we just silently allow it?

I don't have any strong opinion :)