Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issue 2672413003: Out-of-line trace() methods of editing template types. (Closed)

Created:
3 years, 10 months ago by sof
Modified:
3 years, 10 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Out-of-line trace() methods of editing template types. With a simpler trace method infrastructure in place, we can now define trace methods of the editing templates out-of-line. R=haraken BUG=654985 Review-Url: https://codereview.chromium.org/2672413003 Cr-Commit-Position: refs/heads/master@{#448563} Committed: https://chromium.googlesource.com/chromium/src/+/ff9c66f0c118f2cacfdaeda9e384eb2e47b33cdc

Patch Set 1 #

Total comments: 1

Messages

Total messages: 16 (10 generated)
sof
please take a look.
3 years, 10 months ago (2017-02-06 18:38:53 UTC) #7
haraken
LGTM
3 years, 10 months ago (2017-02-07 00:32:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672413003/1
3 years, 10 months ago (2017-02-07 06:26:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ff9c66f0c118f2cacfdaeda9e384eb2e47b33cdc
3 years, 10 months ago (2017-02-07 06:47:55 UTC) #14
sof
https://codereview.chromium.org/2672413003/diff/1/third_party/WebKit/Source/core/editing/EphemeralRange.h File third_party/WebKit/Source/core/editing/EphemeralRange.h (left): https://codereview.chromium.org/2672413003/diff/1/third_party/WebKit/Source/core/editing/EphemeralRange.h#oldcode118 third_party/WebKit/Source/core/editing/EphemeralRange.h:118: DEFINE_INLINE_TRACE() { This was an unused trace method (the ...
3 years, 10 months ago (2017-02-07 11:05:57 UTC) #15
haraken
3 years, 10 months ago (2017-02-07 15:14:18 UTC) #16
Message was sent while issue was closed.
On 2017/02/07 11:05:57, sof wrote:
>
https://codereview.chromium.org/2672413003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/EphemeralRange.h (left):
> 
>
https://codereview.chromium.org/2672413003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/EphemeralRange.h:118:
> DEFINE_INLINE_TRACE() {
> This was an unused trace method (the class is STACK_ALLOCATED()), which I
notice
> the GC plugin doesn't check for. Would it be worth adding a warning for this,
or
> should we just silently allow it?

I don't have any strong opinion :)

Powered by Google App Engine
This is Rietveld 408576698