Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 2672413003: Out-of-line trace() methods of editing template types. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 760 matching lines...) Expand 10 before | Expand all | Expand 10 after
771 selectionWrapper1.base() == selectionWrapper2.base() && 771 selectionWrapper1.base() == selectionWrapper2.base() &&
772 selectionWrapper1.extent() == selectionWrapper2.extent(); 772 selectionWrapper1.extent() == selectionWrapper2.extent();
773 } 773 }
774 774
775 template <typename Strategy> 775 template <typename Strategy>
776 bool VisibleSelectionTemplate<Strategy>::operator==( 776 bool VisibleSelectionTemplate<Strategy>::operator==(
777 const VisibleSelectionTemplate<Strategy>& other) const { 777 const VisibleSelectionTemplate<Strategy>& other) const {
778 return equalSelectionsAlgorithm<Strategy>(*this, other); 778 return equalSelectionsAlgorithm<Strategy>(*this, other);
779 } 779 }
780 780
781 template <typename Strategy>
782 DEFINE_TRACE(VisibleSelectionTemplate<Strategy>) {
783 visitor->trace(m_base);
784 visitor->trace(m_extent);
785 visitor->trace(m_start);
786 visitor->trace(m_end);
787 }
788
781 #ifndef NDEBUG 789 #ifndef NDEBUG
782 790
783 template <typename Strategy> 791 template <typename Strategy>
784 void VisibleSelectionTemplate<Strategy>::showTreeForThis() const { 792 void VisibleSelectionTemplate<Strategy>::showTreeForThis() const {
785 if (!start().anchorNode()) 793 if (!start().anchorNode())
786 return; 794 return;
787 LOG(INFO) << "\n" 795 LOG(INFO) << "\n"
788 << start() 796 << start()
789 .anchorNode() 797 .anchorNode()
790 ->toMarkedTreeString(start().anchorNode(), "S", 798 ->toMarkedTreeString(start().anchorNode(), "S",
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
845 853
846 void showTree(const blink::VisibleSelectionInFlatTree& sel) { 854 void showTree(const blink::VisibleSelectionInFlatTree& sel) {
847 sel.showTreeForThis(); 855 sel.showTreeForThis();
848 } 856 }
849 857
850 void showTree(const blink::VisibleSelectionInFlatTree* sel) { 858 void showTree(const blink::VisibleSelectionInFlatTree* sel) {
851 if (sel) 859 if (sel)
852 sel->showTreeForThis(); 860 sel->showTreeForThis();
853 } 861 }
854 #endif 862 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698