Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2672383002: [ObjC ARC] Converts ios/chrome/browser/ui/ntp/recent_tabs:unit_tests to ARC. (Closed)

Created:
3 years, 10 months ago by lody
Modified:
3 years, 10 months ago
Reviewers:
jif, jif-google, stkhapugin
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/ntp/recent_tabs:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues: Removed the autorelease pool. BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2672383002 Cr-Commit-Position: refs/heads/master@{#448585} Committed: https://chromium.googlesource.com/chromium/src/+/97d545248e030879ef49e0aebb7f9643705360b1

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_unittest.mm View 5 chunks +12 lines, -16 lines 3 comments Download

Messages

Total messages: 18 (11 generated)
lody
Please review this arc update, thanks
3 years, 10 months ago (2017-02-06 15:51:06 UTC) #6
stkhapugin
https://codereview.chromium.org/2672383002/diff/1/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_unittest.mm File ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_unittest.mm (left): https://codereview.chromium.org/2672383002/diff/1/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_unittest.mm#oldcode193 ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_unittest.mm:193: // Sets up a private Autorelease Pool so objects ...
3 years, 10 months ago (2017-02-06 15:52:50 UTC) #7
lody
https://codereview.chromium.org/2672383002/diff/1/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_unittest.mm File ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_unittest.mm (left): https://codereview.chromium.org/2672383002/diff/1/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_unittest.mm#oldcode193 ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_unittest.mm:193: // Sets up a private Autorelease Pool so objects ...
3 years, 10 months ago (2017-02-07 10:06:27 UTC) #9
jif-google
lgtm https://codereview.chromium.org/2672383002/diff/1/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_unittest.mm File ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_unittest.mm (left): https://codereview.chromium.org/2672383002/diff/1/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_unittest.mm#oldcode193 ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_unittest.mm:193: // Sets up a private Autorelease Pool so ...
3 years, 10 months ago (2017-02-07 10:14:21 UTC) #11
jif
lgtm
3 years, 10 months ago (2017-02-07 10:14:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672383002/1
3 years, 10 months ago (2017-02-07 10:30:12 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 10:35:57 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/97d545248e030879ef49e0aebb7f...

Powered by Google App Engine
This is Rietveld 408576698