[ObjC ARC] Converts ios/chrome/browser/ui/ntp/recent_tabs:unit_tests to ARC.

ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller.h"
 
 #import <UIKit/UIKit.h>
 
 #include <memory>
 
-#import "base/mac/scoped_nsautorelease_pool.h"
-#import "base/mac/scoped_nsobject.h"
 #include "base/memory/ptr_util.h"
 #include "components/browser_sync/profile_sync_service.h"
 #include "components/browser_sync/profile_sync_service_mock.h"
 #include "components/signin/core/browser/signin_manager.h"
 #include "components/sync_sessions/open_tabs_ui_delegate.h"
 #include "ios/chrome/browser/browser_state/test_chrome_browser_state.h"
 #include "ios/chrome/browser/signin/signin_manager_factory.h"
 #include "ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.h"
 #include "ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.h"
 #include "ios/chrome/browser/sync/sync_setup_service.h"
 #include "ios/chrome/browser/sync/sync_setup_service_factory.h"
 #include "ios/chrome/browser/sync/sync_setup_service_mock.h"
 #import "ios/chrome/browser/ui/ntp/centering_scrollview.h"
 #import "ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller.h"
 #import "ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.h"
 #include "ios/chrome/test/block_cleanup_test.h"
 #include "ios/chrome/test/ios_chrome_scoped_testing_local_state.h"
 #include "ios/web/public/test/test_web_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #import "third_party/ocmock/OCMock/OCMock.h"
 #import "third_party/ocmock/gtest_support.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 using testing::_;
 using testing::AtLeast;
 using testing::Return;
 
 namespace {
 
 std::unique_ptr<KeyedService> CreateSyncSetupService(
     web::BrowserState* context) {
   ios::ChromeBrowserState* chrome_browser_state =
       ios::ChromeBrowserState::FromBrowserState(context);
@@ skipping 72 matching lines @@
     EXPECT_CALL(*sync_service, GetAuthError())
         .WillRepeatedly(::testing::ReturnRef(no_error_));
     ON_CALL(*sync_service, GetRegisteredDataTypes())
         .WillByDefault(Return(syncer::ModelTypeSet()));
     sync_service->Initialize();
     EXPECT_CALL(*sync_service, IsEngineInitialized())
         .WillRepeatedly(Return(true));
     EXPECT_CALL(*sync_service, GetOpenTabsUIDelegate())
         .WillRepeatedly(Return(nullptr));
 
-    mock_table_view_controller_.reset([[OCMockObject
-        niceMockForClass:[RecentTabsTableViewController class]] retain]);
+    mock_table_view_controller_ =
+        [OCMockObject niceMockForClass:[RecentTabsTableViewController class]];
   }
 
   void SetupSyncState(BOOL signedIn,
                       BOOL syncEnabled,
                       BOOL hasForeignSessions) {
     SigninManager* siginManager = ios::SigninManagerFactory::GetForBrowserState(
         chrome_browser_state_.get());
     if (signedIn)
       siginManager->SetAuthenticatedAccountInfo("test", "test");
     else if (siginManager->IsAuthenticated())
@@ skipping 26 matching lines @@
   void CreateController() {
     // Sets up the test expectations for the Sync Service Observer Bridge.
     // RecentTabsPanelController must be added as an observer of
     // ProfileSyncService changes and removed when it is destroyed.
     browser_sync::ProfileSyncServiceMock* sync_service =
         static_cast<browser_sync::ProfileSyncServiceMock*>(
             IOSChromeProfileSyncServiceFactory::GetForBrowserState(
                 chrome_browser_state_.get()));
     EXPECT_CALL(*sync_service, AddObserver(_)).Times(AtLeast(1));
     EXPECT_CALL(*sync_service, RemoveObserver(_)).Times(AtLeast(1));
-    controller_.reset([[RecentTabsPanelController alloc]
+    controller_ = [[RecentTabsPanelController alloc]
         initWithController:(RecentTabsTableViewController*)
-                               mock_table_view_controller_.get()
-              browserState:chrome_browser_state_.get()]);
+                               mock_table_view_controller_
+              browserState:chrome_browser_state_.get()];
   }
 
  protected:
   web::TestWebThreadBundle thread_bundle_;
   GoogleServiceAuthError no_error_;
   IOSChromeScopedTestingLocalState local_state_;
 
   std::unique_ptr<TestChromeBrowserState> chrome_browser_state_;
   std::unique_ptr<OpenTabsUIDelegateMock> open_tabs_ui_delegate_;
 
   // Must be declared *after* |chrome_browser_state_| so it can outlive it.
-  base::scoped_nsobject<OCMockObject> mock_table_view_controller_;
-  base::scoped_nsobject<RecentTabsPanelController> controller_;
-
-  // Sets up a private Autorelease Pool so objects retained by OCMockObject

[stkhapugin, 2017/02/06 15:52:50]

Please add this to notable issues. 

[lody, 2017/02/07 10:06:27]

Done.

[jif-google, 2017/02/07 10:14:21]

Seems like a bug in OCMock?

-  // are released as soon as possible. Otherwise, weak pointers in the
-  // objects retained by OCMockObject may surface as a BADACC when the
-  // unit test autorelease pool is released.
-  base::mac::ScopedNSAutoreleasePool pool_;
+  OCMockObject* mock_table_view_controller_;
+  RecentTabsPanelController* controller_;
 };
 
 TEST_F(RecentTabsPanelControllerTest, TestConstructorDestructor) {
   CreateController();
-  EXPECT_TRUE(controller_.get());
+  EXPECT_TRUE(controller_);
 }
 
 TEST_F(RecentTabsPanelControllerTest, TestUserSignedOut) {
   [[mock_table_view_controller_ expect]
       refreshUserState:SessionsSyncUserState::USER_SIGNED_OUT];
   SetupSyncState(NO, NO, NO);
   CreateController();
   EXPECT_OCMOCK_VERIFY(mock_table_view_controller_);
 }
 
@@ skipping 16 matching lines @@
 TEST_F(RecentTabsPanelControllerTest, TestUserSignedInSyncOnWithSessions) {
   [[mock_table_view_controller_ expect]
       refreshUserState:SessionsSyncUserState::
                            USER_SIGNED_IN_SYNC_ON_WITH_SESSIONS];
   SetupSyncState(YES, YES, YES);
   CreateController();
   EXPECT_OCMOCK_VERIFY(mock_table_view_controller_);
 }
 
 }  // namespace