Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2672323003: Revert of [Telemetry] Migrate browser_test_runner to use typ as the test runner (Closed)

Created:
3 years, 10 months ago by nednguyen
Modified:
3 years, 10 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Telemetry] Migrate browser_test_runner to use typ as the test runner (patchset #3 id:60001 of https://codereview.chromium.org/2671483002/ ) Reason for revert: Revert so we can try out this change in CHromium first. Original issue's description: > [Telemetry] Migrate browser_test_runner to use typ as the test runner > > This is a reland of https://codereview.chromium.org/2590623002/. The > previous work was reverted because it makes setUpClass & tearDownClass > between every single test, causes the webgl_conformance suite to time > out. > > To fix that, this introduces SetUpProcess & TearDownProcess class > methods to SeriallyExecutedBrowserTestCase which are guaranteed > to be called once before & after the test suite is run. > > Patch 1 is the original work, patch 2 & beyond includes extra logic for > SetUpProcess & TearDownProcess > > BUG=chromium:636153 > > Review-Url: https://codereview.chromium.org/2671483002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c6c6d50501b4c2890c4ac60757717c2b942e5358 TBR=kbr@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:636153 Review-Url: https://codereview.chromium.org/2672323003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b824518419daa7827f6fbe52082b454ac293c76b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+434 lines, -722 lines) Patch
M telemetry/bin/run_browser_tests View 1 chunk +2 lines, -1 line 0 comments Download
M telemetry/examples/browser_tests/failed_tests.py View 2 chunks +2 lines, -2 lines 0 comments Download
D telemetry/examples/browser_tests/process_tests.py View 1 chunk +0 lines, -53 lines 0 comments Download
D telemetry/examples/browser_tests/sample_unittest.py View 1 chunk +0 lines, -12 lines 0 comments Download
M telemetry/examples/browser_tests/simple_browser_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
D telemetry/telemetry/testing/browser_test_context.py View 1 chunk +0 lines, -74 lines 0 comments Download
M telemetry/telemetry/testing/browser_test_runner.py View 1 chunk +309 lines, -33 lines 0 comments Download
M telemetry/telemetry/testing/browser_test_runner_unittest.py View 10 chunks +111 lines, -162 lines 0 comments Download
D telemetry/telemetry/testing/run_browser_tests.py View 1 chunk +0 lines, -357 lines 0 comments Download
M telemetry/telemetry/testing/serially_executed_browser_test_case.py View 4 chunks +8 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
nednguyen
Created Revert of [Telemetry] Migrate browser_test_runner to use typ as the test runner
3 years, 10 months ago (2017-02-06 19:42:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672323003/1
3 years, 10 months ago (2017-02-06 19:42:34 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 19:42:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698